Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
index c8bba03406999ebcf2a926da86f0cb5d7b5ef120..c9d0a2473e610cda25cb853598a9126f01edf07e 100644
--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
@@ -30,6 +30,7 @@
#include "core/html/HTMLDivElement.h"
#include "core/html/media/MediaControls.h"
#include "modules/ModulesExport.h"
+#include "public/platform/media_in_product_help.mojom-blink.h"
namespace blink {
@@ -120,6 +121,8 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void EndScrubbing();
void UpdateCurrentTimeDisplay();
+ void MaybeDispatchDownloadIPHTrigger();
+
DECLARE_VIRTUAL_TRACE();
private:
@@ -212,6 +215,9 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
void OnPanelKeypress();
void OnMediaKeyboardEvent(Event* event) { DefaultEventHandler(event); }
+ void UpdateDownloadInProductHelpState();
+ void DismissDownloadInProductHelp();
+
// Media control elements.
Member<MediaControlOverlayEnclosureElement> overlay_enclosure_;
Member<MediaControlOverlayPlayButtonElement> overlay_play_button_;
@@ -257,6 +263,9 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,
IntSize size_;
bool keep_showing_until_timer_fires_ : 1;
+
+ std::unique_ptr<mojom::blink::MediaInProductHelpPtr> media_in_product_help_;
+ bool media_download_in_product_trigger_observed_ = false;
};
DEFINE_ELEMENT_TYPE_CASTS(MediaControlsImpl, IsMediaControls());

Powered by Google App Engine
This is Rietveld 408576698