Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3250)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/chrome_content_browser_manifest_overlay.json » ('j') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 1466eac5726a39edc75e4ab1241fbd935f0045b2..04a76fa7b0259af04a678fc428ed2610b01867d3 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -137,6 +137,8 @@
#include "components/dom_distiller/core/dom_distiller_switches.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/error_page/common/error_page_switches.h"
+#include "components/feature_engagement_tracker/public/feature_constants.h"
+#include "components/feature_engagement_tracker/public/feature_list.h"
#include "components/google/core/browser/google_util.h"
#include "components/metrics/call_stack_profile_collector.h"
#include "components/metrics/client_info.h"
@@ -2593,6 +2595,9 @@ void ChromeContentBrowserClient::OverrideWebkitPrefs(
web_prefs->video_fullscreen_detection_enabled =
chrome::android::AppHooks::ShouldDetectVideoFullscreen();
+
+ web_prefs->enable_media_in_product_help = base::FeatureList::IsEnabled(
+ feature_engagement_tracker::kIPHMediaDownloadFeature);
#endif // defined(OS_ANDROID)
for (size_t i = 0; i < extra_parts_.size(); ++i)
« no previous file with comments | « chrome/browser/android/tab_android.cc ('k') | chrome/browser/chrome_content_browser_manifest_overlay.json » ('j') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698