Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/public/web/WebMediaIPH.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebMediaIPH.h
diff --git a/third_party/WebKit/public/web/WebMediaIPH.h b/third_party/WebKit/public/web/WebMediaIPH.h
new file mode 100644
index 0000000000000000000000000000000000000000..36f5e531e1a83daced31ce398bb4b82ab20d2e56
--- /dev/null
+++ b/third_party/WebKit/public/web/WebMediaIPH.h
@@ -0,0 +1,39 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef WebMediaIPH_h
chrishtr 2017/06/23 00:39:45 InProductHelp, here and everywhere else in the CL.
Khushal 2017/06/28 05:32:38 Done.
+#define WebMediaIPH_h
+
+#include "public/platform/WebCommon.h"
+
+namespace blink {
+struct WebRect;
+
+class BLINK_EXPORT WebMediaIPHClient {
+ public:
+ virtual ~WebMediaIPHClient() {}
+
+ // Notifies that the IPH widget was hidden.
+ virtual void DidHideMediaIPHWidget() = 0;
+};
+
+// WebMediaIPH provides the functionality to display in-product help UI for
+// media elements.
+class BLINK_EXPORT WebMediaIPH {
chrishtr 2017/06/23 00:39:45 Can you adjust add these methods to WebViewClient
Khushal 2017/06/23 02:11:06 I'm just following the advice on RenderViewImpl wh
chrishtr 2017/06/27 18:22:20 Ok then move them to WebFrameClient?
+ public:
+ virtual ~WebMediaIPH() {}
+
+ // Binds to the client to be notified of changes to the IPH UI.
+ virtual void BindToClient(WebMediaIPHClient*) = 0;
+
+ // Requests that an IPH widget be shown at the provided location.
+ virtual void ShowMediaDownloadIPH(const WebRect&) = 0;
+
+ // Requests that the IPH widget being shown currently is dismissed.
+ virtual void HideMediaDownloadIPH() = 0;
+};
+
+} // namespace blink
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698