Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: components/feature_engagement_tracker/public/feature_list.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/feature_engagement_tracker/public/feature_list.h
diff --git a/components/feature_engagement_tracker/public/feature_list.h b/components/feature_engagement_tracker/public/feature_list.h
index b944137de77a9bfcd958c888b01c14dd4e2c43bc..c75d885effc263412fe69534f7ac6dd1a085d0ec 100644
--- a/components/feature_engagement_tracker/public/feature_list.h
+++ b/components/feature_engagement_tracker/public/feature_list.h
@@ -21,6 +21,10 @@ using FeatureVector = std::vector<const base::Feature*>;
// feature (if any) was selected by the end user.
extern const char kIPHDemoModeFeatureChoiceParam[];
+// The command-line flag used to enable media download IPH feature in the
+// renderer.
+extern const char kEnableMediaDownloadIPH[];
+
namespace {
// Defines a const flags_ui::FeatureEntry::FeatureParam for the given
@@ -49,6 +53,7 @@ DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview");
DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
+DEFINE_VARIATION_PARAM(kIPHMediaDownloadFeature, "IPH_MediaDownload");
#endif // OS_ANDROID
} // namespace
@@ -63,6 +68,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation
VARIATION_ENTRY(kIPHDataSaverDetailFeature),
VARIATION_ENTRY(kIPHDownloadPageFeature),
VARIATION_ENTRY(kIPHDownloadHomeFeature),
+ VARIATION_ENTRY(kIPHMediaDownloadFeature),
#else
VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array.
#endif // OS_ANDROID

Powered by Google App Engine
This is Rietveld 408576698