Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index fedd53caf15a4da66eece46d91d1c156f233c924..a8d2bfaed27bc15e755c39380f390a4b3d567501 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "chrome/renderer/chrome_content_renderer_client.h"
-
#include <memory>
#include <utility>
@@ -46,6 +45,7 @@
#include "chrome/renderer/chrome_render_view_observer.h"
#include "chrome/renderer/content_settings_observer.h"
#include "chrome/renderer/loadtimes_extension_bindings.h"
+#include "chrome/renderer/media/media_iph_impl.h"
#include "chrome/renderer/net/net_error_helper.h"
#include "chrome/renderer/net_benchmarking_extension.h"
#include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
@@ -74,6 +74,7 @@
#include "components/dom_distiller/core/dom_distiller_switches.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/error_page/common/localized_error.h"
+#include "components/feature_engagement_tracker/public/feature_list.h"
#include "components/network_hints/renderer/prescient_networking_dispatcher.h"
#include "components/password_manager/content/renderer/credential_manager_client.h"
#include "components/pdf/renderer/pepper_pdf_host.h"
@@ -1600,3 +1601,14 @@ ChromeContentRendererClient::GetTaskSchedulerInitParams() {
return task_scheduler_util::
GetRendererTaskSchedulerInitParamsFromCommandLine();
}
+
+std::unique_ptr<blink::WebMediaIPH>
+ChromeContentRendererClient::CreateWebMediaIPH(
+ content::RenderFrame* render_frame) {
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ feature_engagement_tracker::kEnableMediaDownloadIPH)) {
+ return nullptr;
+ }
+
+ return base::MakeUnique<MediaIPHImpl>(render_frame);
+}

Powered by Google App Engine
This is Rietveld 408576698