Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1451)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 0a963d1a4ed28f1bc00619cb9caf989bb3bb6465..337658ea6410e75a4266171d435f3359fe38330e 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -135,6 +135,8 @@
#include "components/dom_distiller/core/dom_distiller_switches.h"
#include "components/dom_distiller/core/url_constants.h"
#include "components/error_page/common/error_page_switches.h"
+#include "components/feature_engagement_tracker/public/feature_constants.h"
+#include "components/feature_engagement_tracker/public/feature_list.h"
#include "components/google/core/browser/google_util.h"
#include "components/metrics/call_stack_profile_collector.h"
#include "components/metrics/client_info.h"
@@ -1910,6 +1912,14 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
task_scheduler_util::AddVariationParamsToCommandLine("Renderer",
command_line);
}
+
+ if (process_type == switches::kRendererProcess &&
+ base::FeatureList::IsEnabled(
+ feature_engagement_tracker::kIPHMediaDownloadFeature)) {
+ LOG(ERROR) << "Appending SWITCH FOR RENDEREREREREREFFBKEIVFBOUE";
+ command_line->AppendSwitch(
+ feature_engagement_tracker::kEnableMediaDownloadIPH);
+ }
}
std::string ChromeContentBrowserClient::GetApplicationLocale() {

Powered by Google App Engine
This is Rietveld 408576698