Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: components/feature_engagement_tracker/public/feature_list.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: addressed comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 arraysize(base_feature##Variation), nullptr \ 42 arraysize(base_feature##Variation), nullptr \
43 } 43 }
44 44
45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature. 45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature.
46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy"); 46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy");
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview"); 48 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview");
49 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail"); 49 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
50 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage"); 50 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
51 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome"); 51 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
52 DEFINE_VARIATION_PARAM(kIPHMediaDownloadFeature, "IPH_MediaDownload");
52 #endif // OS_ANDROID 53 #endif // OS_ANDROID
53 54
54 } // namespace 55 } // namespace
55 56
56 // Defines the array of which features should be listed in the chrome://flags 57 // Defines the array of which features should be listed in the chrome://flags
57 // UI to be able to select them alone for demo-mode. The features listed here 58 // UI to be able to select them alone for demo-mode. The features listed here
58 // are possible to enable on their own in demo mode. 59 // are possible to enable on their own in demo mode.
59 constexpr flags_ui::FeatureEntry::FeatureVariation 60 constexpr flags_ui::FeatureEntry::FeatureVariation
60 kIPHDemoModeChoiceVariations[] = { 61 kIPHDemoModeChoiceVariations[] = {
61 #if defined(OS_ANDROID) 62 #if defined(OS_ANDROID)
62 VARIATION_ENTRY(kIPHDataSaverPreviewFeature), 63 VARIATION_ENTRY(kIPHDataSaverPreviewFeature),
63 VARIATION_ENTRY(kIPHDataSaverDetailFeature), 64 VARIATION_ENTRY(kIPHDataSaverDetailFeature),
64 VARIATION_ENTRY(kIPHDownloadPageFeature), 65 VARIATION_ENTRY(kIPHDownloadPageFeature),
65 VARIATION_ENTRY(kIPHDownloadHomeFeature), 66 VARIATION_ENTRY(kIPHDownloadHomeFeature),
67 VARIATION_ENTRY(kIPHMediaDownloadFeature),
66 #else 68 #else
67 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array. 69 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array.
68 #endif // OS_ANDROID 70 #endif // OS_ANDROID
69 }; 71 };
70 72
71 #undef DEFINE_VARIATION_PARAM 73 #undef DEFINE_VARIATION_PARAM
72 #undef VARIATION_ENTRY 74 #undef VARIATION_ENTRY
73 75
74 // Returns all the features that are in use for engagement tracking. 76 // Returns all the features that are in use for engagement tracking.
75 FeatureVector GetAllFeatures(); 77 FeatureVector GetAllFeatures();
76 78
77 } // namespace feature_engagement_tracker 79 } // namespace feature_engagement_tracker
78 80
79 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 81 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698