chrome/blink: Add functionality for in-product help for media elements.

third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/media_controls/elements/MediaControlDownloadButtonElement.h"
 
 #include "core/InputTypeNames.h"
 #include "core/events/Event.h"
+#include "core/frame/LocalFrameClient.h"

[mlamouri (slow - plz ping), 2017/08/16 13:09:30]

Looks like you don't need this include anymore.

[Khushal, 2017/08/16 19:01:23]

Done.

 #include "core/frame/Settings.h"
 #include "core/html/HTMLAnchorElement.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/media/HTMLMediaElementControlsList.h"
 #include "core/html/media/HTMLMediaSource.h"
 #include "core/page/Page.h"
 #include "modules/media_controls/MediaControlsImpl.h"
+#include "modules/media_controls/MediaDownloadInProductHelpManager.h"
+#include "platform/wtf/Functional.h"

[mlamouri (slow - plz ping), 2017/08/16 13:09:30]

Do you still need Functional.h?

[Khushal, 2017/08/16 19:01:22]

Nope.

 #include "public/platform/Platform.h"
 
 namespace blink {
 
 MediaControlDownloadButtonElement::MediaControlDownloadButtonElement(
     MediaControlsImpl& media_controls)
     : MediaControlInputElement(media_controls, kMediaDownloadButton) {
   EnsureUserAgentShadowRoot();
   setType(InputTypeNames::button);
   SetShadowPseudoId(AtomicString("-internal-media-controls-download-button"));
@@ skipping 60 matching lines @@
 
 DEFINE_TRACE(MediaControlDownloadButtonElement) {
   visitor->Trace(anchor_);
   MediaControlInputElement::Trace(visitor);
 }
 
 const char* MediaControlDownloadButtonElement::GetNameForHistograms() const {
   return IsOverflowElement() ? "DownloadOverflowButton" : "DownloadButton";
 }
 
+void MediaControlDownloadButtonElement::UpdateShownState() {
+  MediaControlInputElement::UpdateShownState();
+
+  auto* iph_manager = static_cast<MediaControlsImpl&>(GetMediaControls())

[mlamouri (slow - plz ping), 2017/08/16 13:09:30]

You shouldn't have to static_cast anymore. Also, do you really need the `auto`
here?

[Khushal, 2017/08/16 19:01:22]

That's great. Remove the auto. I had it earlier because I didn't want to do the
ugly static_cast multiple times.

+                          .DownloadInProductHelp();
+  if (iph_manager)
+    iph_manager->SetDownloadButtonState(IsWanted() && DoesFit());

[mlamouri (slow - plz ping), 2017/08/16 13:09:30]

Maybe you should call this `SetDownloadButtonVisible()` because it wasn't clear
to me which state you were passing until I read the implementation.

[Khushal, 2017/08/16 19:01:23]

Done.

+}
+
 void MediaControlDownloadButtonElement::DefaultEventHandler(Event* event) {
   const KURL& url = MediaElement().currentSrc();
   if (event->type() == EventTypeNames::click &&
       !(url.IsNull() || url.IsEmpty())) {
     Platform::Current()->RecordAction(
         UserMetricsAction("Media.Controls.Download"));
     if (!anchor_) {
       HTMLAnchorElement* anchor = HTMLAnchorElement::Create(GetDocument());
       anchor->setAttribute(HTMLNames::downloadAttr, "");
       anchor_ = anchor;
     }
     anchor_->SetURL(url);
     anchor_->DispatchSimulatedClick(event);
   }
   MediaControlInputElement::DefaultEventHandler(event);
 }
 
 }  // namespace blink