Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: components/feature_engagement_tracker/public/feature_list.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: mounir's comments. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature. 45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature.
46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy"); 46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy");
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail"); 48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview"); 49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview");
50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome"); 50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage"); 51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature, 52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature,
53 "IPH_DownloadPageScreenshot"); 53 "IPH_DownloadPageScreenshot");
54 DEFINE_VARIATION_PARAM(kIPHMediaDownloadFeature, "IPH_MediaDownload");
54 #endif // defined(OS_ANDROID) 55 #endif // defined(OS_ANDROID)
55 #if defined(OS_WIN) || defined(OS_LINUX) 56 #if defined(OS_WIN) || defined(OS_LINUX)
56 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow"); 57 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow");
57 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab"); 58 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab");
58 #endif // defined(OS_WIN) || defined(OS_LINUX) 59 #endif // defined(OS_WIN) || defined(OS_LINUX)
59 #if defined(OS_IOS) 60 #if defined(OS_IOS)
60 DEFINE_VARIATION_PARAM(kIPHNewTabTipFeature, "IPH_NewTabTip"); 61 DEFINE_VARIATION_PARAM(kIPHNewTabTipFeature, "IPH_NewTabTip");
61 DEFINE_VARIATION_PARAM(kIPHNewIncognitoTabTipFeature, "IPH_NewIncognitoTabTip"); 62 DEFINE_VARIATION_PARAM(kIPHNewIncognitoTabTipFeature, "IPH_NewIncognitoTabTip");
62 DEFINE_VARIATION_PARAM(kIPHBadgedReadingListFeature, "IPH_BadgedReadingList"); 63 DEFINE_VARIATION_PARAM(kIPHBadgedReadingListFeature, "IPH_BadgedReadingList");
63 #endif // defined(OS_IOS) 64 #endif // defined(OS_IOS)
64 65
65 } // namespace 66 } // namespace
66 67
67 // Defines the array of which features should be listed in the chrome://flags 68 // Defines the array of which features should be listed in the chrome://flags
68 // UI to be able to select them alone for demo-mode. The features listed here 69 // UI to be able to select them alone for demo-mode. The features listed here
69 // are possible to enable on their own in demo mode. 70 // are possible to enable on their own in demo mode.
70 constexpr flags_ui::FeatureEntry::FeatureVariation 71 constexpr flags_ui::FeatureEntry::FeatureVariation
71 kIPHDemoModeChoiceVariations[] = { 72 kIPHDemoModeChoiceVariations[] = {
72 #if defined(OS_ANDROID) 73 #if defined(OS_ANDROID)
73 VARIATION_ENTRY(kIPHDataSaverDetailFeature), 74 VARIATION_ENTRY(kIPHDataSaverDetailFeature),
74 VARIATION_ENTRY(kIPHDataSaverPreviewFeature), 75 VARIATION_ENTRY(kIPHDataSaverPreviewFeature),
75 VARIATION_ENTRY(kIPHDownloadHomeFeature), 76 VARIATION_ENTRY(kIPHDownloadHomeFeature),
76 VARIATION_ENTRY(kIPHDownloadPageFeature), 77 VARIATION_ENTRY(kIPHDownloadPageFeature),
77 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature), 78 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature),
79 VARIATION_ENTRY(kIPHMediaDownloadFeature),
78 #elif defined(OS_WIN) || defined(OS_LINUX) 80 #elif defined(OS_WIN) || defined(OS_LINUX)
79 VARIATION_ENTRY(kIPHIncognitoWindowFeature), 81 VARIATION_ENTRY(kIPHIncognitoWindowFeature),
80 VARIATION_ENTRY(kIPHNewTabFeature), 82 VARIATION_ENTRY(kIPHNewTabFeature),
81 #elif defined(OS_IOS) 83 #elif defined(OS_IOS)
82 VARIATION_ENTRY(kIPHNewTabTipFeature), 84 VARIATION_ENTRY(kIPHNewTabTipFeature),
83 VARIATION_ENTRY(kIPHNewIncognitoTabTipFeature), 85 VARIATION_ENTRY(kIPHNewIncognitoTabTipFeature),
84 VARIATION_ENTRY(kIPHBadgedReadingListFeature), 86 VARIATION_ENTRY(kIPHBadgedReadingListFeature),
85 #else 87 #else
86 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array. 88 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array.
87 #endif 89 #endif
88 }; 90 };
89 91
90 #undef DEFINE_VARIATION_PARAM 92 #undef DEFINE_VARIATION_PARAM
91 #undef VARIATION_ENTRY 93 #undef VARIATION_ENTRY
92 94
93 // Returns all the features that are in use for engagement tracking. 95 // Returns all the features that are in use for engagement tracking.
94 FeatureVector GetAllFeatures(); 96 FeatureVector GetAllFeatures();
95 97
96 } // namespace feature_engagement_tracker 98 } // namespace feature_engagement_tracker
97 99
98 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 100 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698