Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Side by Side Diff: components/feature_engagement_tracker/public/feature_list.h

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 5 #ifndef COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 6 #define COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 44
45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature. 45 // Defines a flags_ui::FeatureEntry::FeatureParam for each feature.
46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy"); 46 DEFINE_VARIATION_PARAM(kIPHDummyFeature, "IPH_Dummy");
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail"); 48 DEFINE_VARIATION_PARAM(kIPHDataSaverDetailFeature, "IPH_DataSaverDetail");
49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview"); 49 DEFINE_VARIATION_PARAM(kIPHDataSaverPreviewFeature, "IPH_DataSaverPreview");
50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome"); 50 DEFINE_VARIATION_PARAM(kIPHDownloadHomeFeature, "IPH_DownloadHome");
51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage"); 51 DEFINE_VARIATION_PARAM(kIPHDownloadPageFeature, "IPH_DownloadPage");
52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature, 52 DEFINE_VARIATION_PARAM(kIPHDownloadPageScreenshotFeature,
53 "IPH_DownloadPageScreenshot"); 53 "IPH_DownloadPageScreenshot");
54 DEFINE_VARIATION_PARAM(kIPHMediaDownloadFeature, "IPH_MediaDownload");
54 #endif // defined(OS_ANDROID) 55 #endif // defined(OS_ANDROID)
55 #if defined(OS_WIN) || defined(OS_LINUX) 56 #if defined(OS_WIN) || defined(OS_LINUX)
56 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow"); 57 DEFINE_VARIATION_PARAM(kIPHIncognitoWindowFeature, "IPH_IncognitoWindow");
57 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab"); 58 DEFINE_VARIATION_PARAM(kIPHNewTabFeature, "IPH_NewTab");
58 #endif // defined(OS_WIN) || defined(OS_LINUX) 59 #endif // defined(OS_WIN) || defined(OS_LINUX)
59 60
60 } // namespace 61 } // namespace
61 62
62 // Defines the array of which features should be listed in the chrome://flags 63 // Defines the array of which features should be listed in the chrome://flags
63 // UI to be able to select them alone for demo-mode. The features listed here 64 // UI to be able to select them alone for demo-mode. The features listed here
64 // are possible to enable on their own in demo mode. 65 // are possible to enable on their own in demo mode.
65 constexpr flags_ui::FeatureEntry::FeatureVariation 66 constexpr flags_ui::FeatureEntry::FeatureVariation
66 kIPHDemoModeChoiceVariations[] = { 67 kIPHDemoModeChoiceVariations[] = {
67 #if defined(OS_ANDROID) 68 #if defined(OS_ANDROID)
68 VARIATION_ENTRY(kIPHDataSaverDetailFeature), 69 VARIATION_ENTRY(kIPHDataSaverDetailFeature),
69 VARIATION_ENTRY(kIPHDataSaverPreviewFeature), 70 VARIATION_ENTRY(kIPHDataSaverPreviewFeature),
70 VARIATION_ENTRY(kIPHDownloadHomeFeature), 71 VARIATION_ENTRY(kIPHDownloadHomeFeature),
71 VARIATION_ENTRY(kIPHDownloadPageFeature), 72 VARIATION_ENTRY(kIPHDownloadPageFeature),
72 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature), 73 VARIATION_ENTRY(kIPHDownloadPageScreenshotFeature),
74 VARIATION_ENTRY(kIPHMediaDownloadFeature),
73 #elif defined(OS_WIN) || defined(OS_LINUX) 75 #elif defined(OS_WIN) || defined(OS_LINUX)
74 VARIATION_ENTRY(kIPHIncognitoWindowFeature), 76 VARIATION_ENTRY(kIPHIncognitoWindowFeature),
75 VARIATION_ENTRY(kIPHNewTabFeature), 77 VARIATION_ENTRY(kIPHNewTabFeature),
76 #else 78 #else
77 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array. 79 VARIATION_ENTRY(kIPHDummyFeature), // Ensures non-empty array.
78 #endif 80 #endif
79 }; 81 };
80 82
81 #undef DEFINE_VARIATION_PARAM 83 #undef DEFINE_VARIATION_PARAM
82 #undef VARIATION_ENTRY 84 #undef VARIATION_ENTRY
83 85
84 // Returns all the features that are in use for engagement tracking. 86 // Returns all the features that are in use for engagement tracking.
85 FeatureVector GetAllFeatures(); 87 FeatureVector GetAllFeatures();
86 88
87 } // namespace feature_engagement_tracker 89 } // namespace feature_engagement_tracker
88 90
89 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_ 91 #endif // COMPONENTS_FEATURE_ENGAGEMENT_TRACKER_PUBLIC_FEATURE_LIST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698