Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: components/feature_engagement_tracker/public/feature_list.cc

Issue 2943983003: chrome/blink: Add functionality for in-product help for media elements. (Closed)
Patch Set: tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /// Copyright 2017 The Chromium Authors. All rights reserved. 1 /// Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/feature_engagement_tracker/public/feature_list.h" 5 #include "components/feature_engagement_tracker/public/feature_list.h"
6 6
7 #include "components/feature_engagement_tracker/public/feature_constants.h" 7 #include "components/feature_engagement_tracker/public/feature_constants.h"
8 8
9 namespace feature_engagement_tracker { 9 namespace feature_engagement_tracker {
10 10
11 namespace { 11 namespace {
12 // Whenever a feature is added to |kAllFeatures|, it should also be added as 12 // Whenever a feature is added to |kAllFeatures|, it should also be added as
13 // DEFINE_VARIATION_PARAM in the header, and also added to the 13 // DEFINE_VARIATION_PARAM in the header, and also added to the
14 // |kIPHDemoModeChoiceVariations| array. 14 // |kIPHDemoModeChoiceVariations| array.
15 const base::Feature* kAllFeatures[] = { 15 const base::Feature* kAllFeatures[] = {
16 &kIPHDummyFeature, // Ensures non-empty array for all platforms. 16 &kIPHDummyFeature, // Ensures non-empty array for all platforms.
17 #if defined(OS_ANDROID) 17 #if defined(OS_ANDROID)
18 &kIPHDataSaverDetailFeature, 18 &kIPHDataSaverDetailFeature,
19 &kIPHDataSaverPreviewFeature, 19 &kIPHDataSaverPreviewFeature,
20 &kIPHDownloadHomeFeature, 20 &kIPHDownloadHomeFeature,
21 &kIPHDownloadPageFeature, 21 &kIPHDownloadPageFeature,
22 &kIPHDownloadPageScreenshotFeature, 22 &kIPHDownloadPageScreenshotFeature,
23 &kIPHMediaDownloadFeature,
23 #endif // defined(OS_ANDROID) 24 #endif // defined(OS_ANDROID)
24 #if defined(OS_WIN) || defined(OS_LINUX) 25 #if defined(OS_WIN) || defined(OS_LINUX)
25 &kIPHIncognitoWindowFeature, 26 &kIPHIncognitoWindowFeature,
26 &kIPHNewTabFeature, 27 &kIPHNewTabFeature,
27 #endif // defined(OS_WIN) || defined(OS_LINUX) 28 #endif // defined(OS_WIN) || defined(OS_LINUX)
28 }; 29 };
29 } // namespace 30 } // namespace
30 31
31 const char kIPHDemoModeFeatureChoiceParam[] = "chosen_feature"; 32 const char kIPHDemoModeFeatureChoiceParam[] = "chosen_feature";
32 33
33 std::vector<const base::Feature*> GetAllFeatures() { 34 std::vector<const base::Feature*> GetAllFeatures() {
34 return std::vector<const base::Feature*>( 35 return std::vector<const base::Feature*>(
35 kAllFeatures, kAllFeatures + arraysize(kAllFeatures)); 36 kAllFeatures, kAllFeatures + arraysize(kAllFeatures));
36 } 37 }
37 38
38 } // namespace feature_engagement_tracker 39 } // namespace feature_engagement_tracker
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698