Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: ui/keyboard/keyboard_util.cc

Issue 2943973003: keyboard::SendKeyEvent() doesn't need to send events to InputMethod directly. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/keyboard/keyboard_util.cc
diff --git a/ui/keyboard/keyboard_util.cc b/ui/keyboard/keyboard_util.cc
index 069ee13c60979d99bd0af60a0e32abacda80cf8d..4dbe12a0890b4a39091212878ff3d102057f081a 100644
--- a/ui/keyboard/keyboard_util.cc
+++ b/ui/keyboard/keyboard_util.cc
@@ -348,13 +348,9 @@ bool SendKeyEvent(const std::string type,
code,
dom_code,
modifiers);
- if (input_method) {
- input_method->DispatchKeyEvent(&event);
- } else {
- ui::EventDispatchDetails details =
- host->event_sink()->OnEventFromSource(&event);
- CHECK(!details.dispatcher_destroyed);
- }
+ ui::EventDispatchDetails details =
+ host->event_sink()->OnEventFromSource(&event);
+ CHECK(!details.dispatcher_destroyed);
sadrul 2017/06/20 12:56:10 Just to confirm: is there a difference to whether
Hadi 2017/06/20 14:41:11 WindowEventDispatcher sends the key event to Input
}
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698