Include SkTypes to fix Android frameworks build

Include SkTypes to fix Android frameworks build

Since Android's defines are included in SkUserConfig (rather than
being defined in the build file), we need to include something that
includes SkUserConfig (transitively; meaning just about anything)
before we can use any build macros. Include SkTypes, "the correct
way to get access to the config system" so that
SK_BUILD_FOR_ANDROID is defined before querying it.

Committed: http://code.google.com/p/skia/source/detail?r=14914

[scroggo, 2014-05-28 14:23:16]

This issue comes up occasionally. In theory I'd like to eliminate Android's need
of SkUserConfig, to keep this issue comes up from time to time, but that may not
be realistic. For now, this gets us building again.

I included SkUserConfig directly, with a comment why it's first. Alternatively,
I could have just moved the include for SkPictureRecorder first. There is an
independent justification for that (some projects include the cpp's
corresponding header first; we're inconsistent about it), but it leaves us with
an order which does not necessarily agree with other decisions we've made for a
non-obvious reason.

[scroggo, 2014-05-28 14:23:16]

This issue comes up occasionally. In theory I'd like to eliminate Android's need
of SkUserConfig, to keep this issue comes up from time to time, but that may not
be realistic. For now, this gets us building again.

I included SkUserConfig directly, with a comment why it's first. Alternatively,
I could have just moved the include for SkPictureRecorder first. There is an
independent justification for that (some projects include the cpp's
corresponding header first; we're inconsistent about it), but it leaves us with
an order which does not necessarily agree with other decisions we've made for a
non-obvious reason.

[mtklein, 2014-05-28 14:25:57]

https://codereview.chromium.org/294393011/diff/1/src/core/SkPictureRecorder.cpp
File src/core/SkPictureRecorder.cpp (right):

https://codereview.chromium.org/294393011/diff/1/src/core/SkPictureRecorder.c...
src/core/SkPictureRecorder.cpp:9: #include "SkUserConfig.h"
IIRC, the proscribed way to do this is #include "SkTypes.h", which includes
SkPre-,SkUser-,and then SkPostConfig?

[scroggo, 2014-05-28 14:44:17]

https://codereview.chromium.org/294393011/diff/1/src/core/SkPictureRecorder.cpp
File src/core/SkPictureRecorder.cpp (right):

https://codereview.chromium.org/294393011/diff/1/src/core/SkPictureRecorder.c...
src/core/SkPictureRecorder.cpp:9: #include "SkUserConfig.h"
On 2014/05/28 14:25:58, mtklein wrote:
> IIRC, the proscribed way to do this is #include "SkTypes.h", which includes
> SkPre-,SkUser-,and then SkPostConfig?

I included SkUserConfig because that's the file I actually care about, but that
sounds familiar. Just found a statement in the style guide to confirm.

Done.

[mtklein, 2014-05-28 14:52:09]

lgtm

[djsollen, 2014-05-28 14:54:08]

lgtm

[scroggo, 2014-05-28 14:57:09]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2014-05-28 14:57:28]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/scroggo@google.com/294393011/20001

[commit-bot: I haz the power, 2014-05-28 15:02:45]

Change committed as 14914