Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294393010: Hook up external monitor detection in PepperFlashDRM. (Closed)

Created:
6 years, 7 months ago by bbudge
Modified:
6 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Hook up external monitor detection in PepperFlashDRM. BUG=375462 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273153

Patch Set 1 #

Patch Set 2 : Add PPB_Flash_DRM_1_1 to the proxy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private_flash.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bbudge
6 years, 7 months ago (2014-05-27 23:28:26 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 7 months ago (2014-05-27 23:46:56 UTC) #2
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-27 23:50:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/294393010/1
6 years, 7 months ago (2014-05-27 23:51:34 UTC) #4
bbudge
The CQ bit was unchecked by bbudge@chromium.org
6 years, 7 months ago (2014-05-27 23:52:49 UTC) #5
bbudge
Re-reading the bug, I realized we haven't added the 1.1 api to the proxy.
6 years, 7 months ago (2014-05-27 23:57:21 UTC) #6
bbudge
The CQ bit was checked by bbudge@chromium.org
6 years, 7 months ago (2014-05-28 00:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/294393010/20001
6 years, 7 months ago (2014-05-28 00:34:52 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 03:48:50 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 05:28:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 273153

Powered by Google App Engine
This is Rietveld 408576698