Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 294393009: [webcrypto] Order jwk_ops the same way as Key.usages. (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 6 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[webcrypto] Order JWK's key_ops the same way as Key.usages. BUG=378050, 245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273787

Patch Set 1 #

Patch Set 2 : Add a comment 'splaining to keep it sorted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/child/webcrypto/webcrypto_util.cc View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
No corresponding unit-test because it seemed silly to add more. However, I am in the ...
6 years, 7 months ago (2014-05-27 23:23:52 UTC) #1
eroman
Easy review when you get the chance.
6 years, 6 months ago (2014-05-29 22:30:00 UTC) #2
Ryan Sleevi
lgtm
6 years, 6 months ago (2014-05-30 01:17:01 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 6 months ago (2014-05-30 01:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/294393009/20001
6 years, 6 months ago (2014-05-30 01:48:42 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:25:36 UTC) #6
Message was sent while issue was closed. 
Change committed as 273787

Powered by Google App Engine
This is Rietveld 408576698