Issue 294393004: Simplify SVGResourcesCycleSolver::resourceContainsCycles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 294393004: Simplify SVGResourcesCycleSolver::resourceContainsCycles (Closed)

Created:
6 years, 7 months ago by fs

Modified:
6 years, 7 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Simplify SVGResourcesCycleSolver::resourceContainsCycles Modify the child traversal to use pre-order. This allows the case for |renderer| to be sunk into the loop, reducing the amount of code somewhat. This also fixes a bug where the child traversal would not traverse its the children of node that did not reference any resources. BUG=351713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174862

Patch Set 1 #

Patch Set 2 : Fold the method; Use pre-order traversal to avoid recursion. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -20 lines)			Patch
A	LayoutTests/svg/custom/pattern-content-cycle-w-resourceless-container.html	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/custom/pattern-content-cycle-w-resourceless-container-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/SVGResourcesCycleSolver.cpp	View	1	2 chunks	+4 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

f(malita)

Nice, LGTM! Please update the description to match set 2.

6 years, 7 months ago (2014-05-27 13:23:59 UTC) #2

On 2014/05/27 13:23:59, Florin Malita wrote: > Nice, LGTM! > > Please update the description ...

6 years, 7 months ago (2014-05-27 13:50:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/294393004/20001

6 years, 7 months ago (2014-05-27 13:51:28 UTC) #5

Message was sent while issue was closed.

Change committed as 174862

Expand Messages | Collapse Messages