Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: components/storage_monitor/portable_device_watcher_win.cc

Issue 2943923002: Use TaskScheduler instead of SequencedWorkerPool in portable_device_watcher_win.cc (Closed)
Patch Set: Use SequencedTaskRunners Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/storage_monitor/portable_device_watcher_win.cc
diff --git a/components/storage_monitor/portable_device_watcher_win.cc b/components/storage_monitor/portable_device_watcher_win.cc
index 62a08a0c39afbbe1c72921859149ba45472e8257..d6911e2c655fa667c36e4ca049b8c4d6b91a5629 100644
--- a/components/storage_monitor/portable_device_watcher_win.cc
+++ b/components/storage_monitor/portable_device_watcher_win.cc
@@ -17,7 +17,8 @@
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/threading/sequenced_worker_pool.h"
+#include "base/task_scheduler/post_task.h"
+#include "base/threading/thread_restrictions.h"
#include "base/win/scoped_co_mem.h"
#include "base/win/scoped_comptr.h"
#include "base/win/scoped_propvariant.h"
@@ -32,9 +33,6 @@ namespace {
// Name of the client application that communicates with the MTP device.
const base::char16 kClientName[] = L"Chromium";
-// Name of the sequenced task runner.
-const char kMediaTaskRunnerName[] = "media-task-runner";
-
// Returns true if |data| represents a class of portable devices.
bool IsPortableDeviceStructure(LPARAM data) {
DEV_BROADCAST_HDR* broadcast_hdr =
@@ -317,8 +315,8 @@ bool IsMassStoragePortableDevice(const base::string16& pnp_device_id,
base::string16 GetDeviceNameOnBlockingThread(
IPortableDeviceManager* portable_device_manager,
const base::string16& pnp_device_id) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
DCHECK(portable_device_manager);
+ base::ThreadRestrictions::AssertIOAllowed();
base::string16 name;
GetFriendlyName(pnp_device_id, portable_device_manager, &name) ||
GetDeviceDescription(pnp_device_id, portable_device_manager, &name) ||
@@ -331,8 +329,8 @@ base::string16 GetDeviceNameOnBlockingThread(
bool GetDeviceStorageObjectsOnBlockingThread(
const base::string16& pnp_device_id,
PortableDeviceWatcherWin::StorageObjects* storage_objects) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
DCHECK(storage_objects);
+ base::ThreadRestrictions::AssertIOAllowed();
base::win::ScopedComPtr<IPortableDevice> device;
if (!SetUp(pnp_device_id, &device))
return false;
@@ -369,10 +367,10 @@ bool GetDeviceInfoOnBlockingThread(
IPortableDeviceManager* portable_device_manager,
const base::string16& pnp_device_id,
PortableDeviceWatcherWin::DeviceDetails* device_details) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
DCHECK(portable_device_manager);
DCHECK(device_details);
DCHECK(!pnp_device_id.empty());
+ base::ThreadRestrictions::AssertIOAllowed();
device_details->name = GetDeviceNameOnBlockingThread(portable_device_manager,
pnp_device_id);
if (IsMassStoragePortableDevice(pnp_device_id, device_details->name))
@@ -388,7 +386,7 @@ bool GetDeviceInfoOnBlockingThread(
// returns true and fills in |portable_device_mgr|. On failure, returns false.
bool GetPortableDeviceManager(
base::win::ScopedComPtr<IPortableDeviceManager>* portable_device_mgr) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
+ base::ThreadRestrictions::AssertIOAllowed();
HRESULT hr = ::CoCreateInstance(
__uuidof(PortableDeviceManager), NULL, CLSCTX_INPROC_SERVER,
IID_PPV_ARGS(portable_device_mgr->GetAddressOf()));
@@ -406,8 +404,8 @@ bool GetPortableDeviceManager(
// false.
bool EnumerateAttachedDevicesOnBlockingThread(
PortableDeviceWatcherWin::Devices* devices) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
DCHECK(devices);
+ base::ThreadRestrictions::AssertIOAllowed();
base::win::ScopedComPtr<IPortableDeviceManager> portable_device_mgr;
if (!GetPortableDeviceManager(&portable_device_mgr))
return false;
@@ -441,8 +439,8 @@ bool EnumerateAttachedDevicesOnBlockingThread(
bool HandleDeviceAttachedEventOnBlockingThread(
const base::string16& pnp_device_id,
PortableDeviceWatcherWin::DeviceDetails* device_details) {
- DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
DCHECK(device_details);
+ base::ThreadRestrictions::AssertIOAllowed();
base::win::ScopedComPtr<IPortableDeviceManager> portable_device_mgr;
if (!GetPortableDeviceManager(&portable_device_mgr))
return false;
@@ -503,10 +501,9 @@ PortableDeviceWatcherWin::~PortableDeviceWatcherWin() {
void PortableDeviceWatcherWin::Init(HWND hwnd) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
notifications_ = RegisterPortableDeviceNotification(hwnd);
- base::SequencedWorkerPool* pool = content::BrowserThread::GetBlockingPool();
- media_task_runner_ = pool->GetSequencedTaskRunnerWithShutdownBehavior(
- pool->GetNamedSequenceToken(kMediaTaskRunnerName),
- base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
+ media_task_runner_ = base::CreateSequencedTaskRunnerWithTraits(
+ {base::MayBlock(), base::TaskPriority::BACKGROUND,
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN});
EnumerateAttachedDevices();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698