Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: chrome/browser/android/webapk/webapk_update_manager.cc

Issue 2943913002: [Android WebAPK] Make webapk_installer.cc return proto as base64 string
Patch Set: Merge branch 'background_updates0_5' into background_updates00 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_manager.cc
diff --git a/chrome/browser/android/webapk/webapk_update_manager.cc b/chrome/browser/android/webapk/webapk_update_manager.cc
index 1b721b9e28bc920dea06f50a3f08d7c0ef00bf1c..7d4eed9747f602a2db354fd7432c1243ffd902bf 100644
--- a/chrome/browser/android/webapk/webapk_update_manager.cc
+++ b/chrome/browser/android/webapk/webapk_update_manager.cc
@@ -35,8 +35,11 @@ namespace {
// Called with the serialized proto to send to the WebAPK server.
void OnBuiltProto(const JavaRef<jobject>& java_callback,
- std::unique_ptr<std::vector<uint8_t>> proto) {
- base::android::RunCallbackAndroid(java_callback, *proto);
+ std::unique_ptr<std::string> proto) {
+ JNIEnv* env = base::android::AttachCurrentThread();
+ base::android::ScopedJavaLocalRef<jstring> java_proto =
+ base::android::ConvertUTF8ToJavaString(env, *proto);
+ base::android::RunCallbackAndroid(java_callback, java_proto);
}
// Called after the update either succeeds or fails.
@@ -136,7 +139,7 @@ static void UpdateWebApk(JNIEnv* env,
const JavaParamRef<jstring>& java_webapk_package,
const JavaParamRef<jstring>& java_start_url,
const JavaParamRef<jstring>& java_short_name,
- const JavaParamRef<jbyteArray>& java_serialized_proto,
+ const JavaParamRef<jstring>& java_serialized_proto,
const JavaParamRef<jobject>& java_callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -155,9 +158,9 @@ static void UpdateWebApk(JNIEnv* env,
ConvertJavaStringToUTF8(env, java_webapk_package);
GURL start_url = GURL(ConvertJavaStringToUTF8(env, java_start_url));
base::string16 short_name = ConvertJavaStringToUTF16(env, java_short_name);
- std::unique_ptr<std::vector<uint8_t>> serialized_proto =
- base::MakeUnique<std::vector<uint8_t>>();
- JavaByteArrayToByteVector(env, java_serialized_proto, serialized_proto.get());
+ std::unique_ptr<std::string> serialized_proto =
+ base::MakeUnique<std::string>();
+ ConvertJavaStringToUTF8(env, java_serialized_proto, serialized_proto.get());
WebApkInstallService::Get(profile)->UpdateAsync(
webapk_package, start_url, short_name, std::move(serialized_proto),

Powered by Google App Engine
This is Rietveld 408576698