build/config/compiler/BUILD.gn - Issue 2943863002: Set using_sanitizer if use_cfi_diag is true.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2943863002: Set using_sanitizer if use_cfi_diag is true. (Closed)

Patch Set: Sanitizers not supported in official builds Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index aab7557f9b466a68addf403544518ed4f004f2fa..b156970abb1e766cc685476fcc7b46ca9af90dc1 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -332,9 +332,7 @@ config("compiler") {

"-Wl,-z,relro",

]

if (!using_sanitizer) {

- if (!use_cfi_diag) {

- ldflags += [ "-Wl,-z,defs" ]

- }

+ ldflags += [ "-Wl,-z,defs" ]

# Functions interposed by the sanitizers can make ld think

# that some libraries aren't needed when they actually are,

« no previous file with comments | « no previous file | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »