build/config/sanitizers/sanitizers.gni - Issue 2943863002: Set using_sanitizer if use_cfi_diag is true.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2943863002: Set using_sanitizer if use_cfi_diag is true. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/sanitizers/sanitizers.gni

diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni

index f59770a4148ea348f0bdeb9c22d946fa873df75a..9b5f02d55ea7fc248e2ae8ea9c7eaaaa598e9766 100644

--- a/build/config/sanitizers/sanitizers.gni

+++ b/build/config/sanitizers/sanitizers.gni

@@ -165,7 +165,7 @@ if ((use_afl || use_libfuzzer) && sanitizer_coverage_flags == "") {

using_sanitizer =

is_asan || is_lsan || is_tsan || is_msan || is_ubsan || is_ubsan_null ||

- is_ubsan_vptr || is_ubsan_security || use_sanitizer_coverage

+ is_ubsan_vptr || is_ubsan_security || use_sanitizer_coverage || use_cfi_diag

assert(!using_sanitizer || is_clang,

"Sanitizers (is_*san) require setting is_clang = true in 'gn args'")