Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: net/http/http_stream_factory_impl_job_controller.cc

Issue 2943853002: Convert CHECK to DCHECK in HttpStreamFactoryImpl::JobController (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job_controller.cc
diff --git a/net/http/http_stream_factory_impl_job_controller.cc b/net/http/http_stream_factory_impl_job_controller.cc
index a3134b80f80058eba39c10ff44d428ed0705aa4e..42644407186966631be2f2214e3a95110ce7aec2 100644
--- a/net/http/http_stream_factory_impl_job_controller.cc
+++ b/net/http/http_stream_factory_impl_job_controller.cc
@@ -107,9 +107,7 @@ HttpStreamFactoryImpl::JobController::~JobController() {
alternative_job_.reset();
bound_job_ = nullptr;
if (pac_request_) {
- // TODO(mmenke): Convert this to a DCHECK once https://crbug.com/723589 is
- // resolved.
- CHECK_EQ(STATE_RESOLVE_PROXY_COMPLETE, next_state_);
+ DCHECK_EQ(STATE_RESOLVE_PROXY_COMPLETE, next_state_);
session_->proxy_service()->CancelPacRequest(pac_request_);
}
net_log_.EndEvent(NetLogEventType::HTTP_STREAM_JOB_CONTROLLER);
@@ -711,9 +709,7 @@ int HttpStreamFactoryImpl::JobController::DoLoop(int rv) {
}
int HttpStreamFactoryImpl::JobController::DoResolveProxy() {
- // TODO(mmenke): Convert this to a DCHECK once https://crbug.com/723589 is
- // resolved.
- CHECK(!pac_request_);
+ DCHECK(!pac_request_);
DCHECK(session_);
next_state_ = STATE_RESOLVE_PROXY_COMPLETE;
@@ -1245,9 +1241,7 @@ int HttpStreamFactoryImpl::JobController::ReconsiderProxyAfterError(Job* job,
int error) {
// ReconsiderProxyAfterError() should only be called when the last job fails.
DCHECK(!(alternative_job_ && main_job_));
- // TODO(mmenke): Convert this to a DCHECK once https://crbug.com/723589 is
- // resolved.
- CHECK(!pac_request_);
+ DCHECK(!pac_request_);
DCHECK(session_);
if (!job->should_reconsider_proxy())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698