Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6420)

Unified Diff: chrome/browser/ui/browser_list.h

Issue 2943693002: Fix TryToCloseBrowserList not checking for null callbacks (Closed)
Patch Set: Incorporate treib@'s comment change into the CL. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_list.h
diff --git a/chrome/browser/ui/browser_list.h b/chrome/browser/ui/browser_list.h
index 7fff263786c280e118af090521c2688d8ea1551e..ba78df21b260beff89f46603d9ad74a77e13532b 100644
--- a/chrome/browser/ui/browser_list.h
+++ b/chrome/browser/ui/browser_list.h
@@ -92,13 +92,14 @@ class BrowserList {
static void CloseAllBrowsersWithProfile(Profile* profile);
// Closes all browsers for |profile| across all desktops. Uses
- // TryToCloseBrowserList() to do the actual closing. Trigger any
- // OnBeforeUnload events if |if_force| is false. If all OnBeforeUnload events
- // are confirmed or |skip_beforeunload| is true, |on_close_success| is called,
- // otherwise |on_close_aborted| is called.
- // Note that if there is any browser window has been used before, user
- // should always has a chance to save his or her work before closing windows
- // without trigger beforeunload event.
+ // TryToCloseBrowserList() to do the actual closing. Triggers any
+ // OnBeforeUnload events unless |skip_beforeunload| is true. If all
+ // OnBeforeUnload events are confirmed or |skip_beforeunload| is true,
+ // |on_close_success| is called, otherwise |on_close_aborted| is called. Both
+ // callbacks may be null.
+ // Note that if there is any browser window that has been used before, the
+ // user should always have a chance to save their work before closing windows
+ // without triggering beforeunload events.
static void CloseAllBrowsersWithProfile(Profile* profile,
const CloseCallback& on_close_success,
const CloseCallback& on_close_aborted,
« no previous file with comments | « no previous file | chrome/browser/ui/browser_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698