third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc - Issue 2943573002: Make NGInlineItemsBuilder construct whitespace-collapsed offset mapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

Issue 2943573002: Make NGInlineItemsBuilder construct whitespace-collapsed offset mapping (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

index a7769672fead627c8b0e76b01a1809d9751df38b..b16cc9bd40730bd1cf3462a27e75ddec068945af 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc

@@ -208,6 +208,7 @@ void NGInlineNode::CollectInlines(LayoutObject* start, LayoutBlockFlow* block) {

builder.EnterBlock(block->Style());

LayoutObject* next_sibling = CollectInlines(start, block, &builder);

builder.ExitBlock();

+ builder.Finalize();

MutableData().text_content_ = builder.ToString();

DCHECK(!next_sibling || !next_sibling->IsInline());