Enable GRC [NOT SUBMITTED]

Enable GRC

This CL enables GlobalResourceCoordinator by default. Several projects are
depending on GRC service. For features using GRC, they should be guarded
by their own feature flags and run their own finch trials.

BUG=691886

[Zhen Wang, 2017-06-15 22:30:37]

The CQ bit was checked by zhenw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 22:31:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhen Wang, 2017-06-15 22:33:19]

Description was changed from

==========
Enable GRC
==========

to

==========
Enable GRC

This CL enables GlobalResourceCoordinator by default. Several projects are
depending on GRC service. For features using GRC, they should be guarded
by their own feature flags and run their own finch trials.

BUG=691886
==========

[Zhen Wang, 2017-06-15 22:35:44]

zhenw@chromium.org changed reviewers:
+ oysteine@chromium.org

[Zhen Wang, 2017-06-15 22:35:44]

ptal

[oystein (OOO til 10th of July), 2017-06-15 22:51:28]

lgtm

[commit-bot: I haz the power, 2017-06-15 23:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 23:20:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fmeawad, 2017-06-16 14:46:18]

On 2017/06/15 22:51:28, oystein wrote:
> lgtm

There seem to be a failure in the unit tests with patch, Zhen are you looking at
it or do you need help?

[Zhen Wang, 2017-06-16 16:08:38]

The CQ bit was checked by zhenw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 16:09:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 16:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 16:48:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhen Wang, 2017-06-16 17:17:59]

On 2017/06/16 14:46:18, fmeawad wrote:
> On 2017/06/15 22:51:28, oystein wrote:
> > lgtm
> 
> There seem to be a failure in the unit tests with patch, Zhen are you looking
at
> it or do you need help?

Seems bots are flaky. Will retry a few times.

[Zhen Wang, 2017-06-16 21:05:15]

Hi Oystein,

It seems the browser crashes when ResourceCoordinatorWebContentsObserver is
constructed. Is service manager available in tests?

[ RUN      ]
FullscreenControllerStateUnitTest.OneCapturedTabFullscreenedBeforeBrowserFullscreen
Xlib:  extension "RANDR" missing on display ":99".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x0000042fcd67 base::debug::StackTrace::StackTrace()
#1 0x0000042fc8df base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f32283a4330 <unknown>
#3 0x000007acc809
ResourceCoordinatorWebContentsObserver::ResourceCoordinatorWebContentsObserver()
#4 0x000006040503 content::WebContentsUserData<>::CreateForWebContents()
#5 0x00000603e778 TabHelpers::AttachTabHelpers()
#6 0x00000607fe72 chrome::Navigate()
#7 0x0000010f8537 BrowserWithTestWindowTest::AddTab()
#8 0x000000f7f2bd
FullscreenControllerStateUnitTest_OneCapturedTabFullscreenedBeforeBrowserFullscreen_Test::TestBody()
#9 0x000001f968d6 testing::Test::Run()
#10 0x000001f973b0 testing::TestInfo::Run()
#11 0x000001f978d7 testing::TestCase::Run()
#12 0x000001f9ea37 testing::internal::UnitTestImpl::RunAllTests()
#13 0x000001f9e6c7 testing::UnitTest::Run()
#14 0x000003832901 base::TestSuite::Run()
#15 0x000003834670 base::(anonymous namespace)::LaunchUnitTestsInternal()
#16 0x0000038344e4 base::LaunchUnitTests()
#17 0x00000382b94a main
#18 0x7f3221daef45 __libc_start_main
#19 0x0000006516fd <unknown>
  r8: 0000000000000000  r9: 0000000000000001 r10: ffffd501598c3529 r11:
00007f3221f16cf0
 r12: 00002afea681aa00 r13: 00007ffe589f6558 r14: 00002afea62e4b00 r15:
00002afea62e4b10
  di: 000000000ae9f948  si: 00002afea661a650  bp: 00007ffe589f64f8  bx:
00002afea673b210
  dx: 00002afea661a650  ax: 0000000000000000  cx: 000000000ad7e8d0  sp:
00007ffe589f6140
  ip: 0000000007acc809 efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

[Zhen Wang, 2017-06-19 15:57:30]

I confirmed that |content::ServiceManagerConnection::GetForProcess()| is null in
ResourceCoordinatorWebContentsObserver's constructor.

Oystein, in the test, is this something service manager should set up or GRC
should set up? Do you know how to do it?

[chromium-reviews, 2017-06-20 17:22:05]

Probably browsertests need to set this up themselves; I guess we should
make the observer tolerant of this case.

An example browsertest that uses this is here:
https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_video_capt...

On Mon, Jun 19, 2017 at 8:57 AM <zhenw@chromium.org> wrote:

> I confirmed that |content::ServiceManagerConnection::GetForProcess()| is
> null in
> ResourceCoordinatorWebContentsObserver's constructor.
>
> Oystein, in the test, is this something service manager should set up or
> GRC
> should set up? Do you know how to do it?
>
> https://codereview.chromium.org/2943563002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Zhen Wang, 2017-06-20 18:05:09]

zhenw@chromium.org changed reviewers:
+ lpy@chromium.org

[Zhen Wang, 2017-06-20 18:05:10]

Peiyong and Oystein, do you mind taking this over if this is urgent (as I am OOO
for a week)?

[oystein (OOO til 10th of July), 2017-06-20 20:30:06]

On 2017/06/20 at 18:05:10, zhenw wrote:
> Peiyong and Oystein, do you mind taking this over if this is urgent (as I am
OOO for a week)?

Yep I'll grab it.

[Zhen Wang, 2017-06-27 23:25:16]

zhenw@chromium.org changed reviewers:
+ matthalp@google.com

[Zhen Wang, 2017-06-27 23:25:17]

On 2017/06/20 20:30:06, oystein (OOO til 10th of July) wrote:
> On 2017/06/20 at 18:05:10, zhenw wrote:
> > Peiyong and Oystein, do you mind taking this over if this is urgent (as I am
> OOO for a week)?
> 
> Yep I'll grab it.

I am giving this to Matt now because Oystein is OOO.

[Zhen Wang, 2017-06-28 02:27:24]

The CQ bit was checked by zhenw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 02:27:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 03:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 03:19:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhen Wang, 2017-06-30 16:49:28]

Closing this with out landing, as Matt will land his version.