Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: runtime/vm/profiler.cc

Issue 2943543002: Don't consider --profile-vm when collecting allocation samples; introduce a separate --profile-vm-al (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.cc
diff --git a/runtime/vm/profiler.cc b/runtime/vm/profiler.cc
index 840f438359bb62e7f0aca86a650467282959d987..9aa683b7caf609e29592e1750a20d962b83e47d3 100644
--- a/runtime/vm/profiler.cc
+++ b/runtime/vm/profiler.cc
@@ -52,6 +52,10 @@ DEFINE_FLAG(bool, profile_vm, true, "Always collect native stack traces.");
#else
DEFINE_FLAG(bool, profile_vm, false, "Always collect native stack traces.");
#endif
+DEFINE_FLAG(bool,
+ profile_vm_allocation,
+ false,
+ "Collect native stack traces when tracing Dart allocations.");
#ifndef PRODUCT
@@ -1182,7 +1186,7 @@ void Profiler::SampleAllocation(Thread* thread, intptr_t cid) {
Sample* sample = SetupSample(thread, sample_buffer, os_thread->trace_id());
sample->SetAllocationCid(cid);
- if (FLAG_profile_vm) {
+ if (FLAG_profile_vm_allocation) {
ProfilerNativeStackWalker native_stack_walker(
(isolate != NULL) ? isolate->main_port() : ILLEGAL_PORT, sample,
sample_buffer, stack_lower, stack_upper, pc, fp, sp);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698