Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 294353002: Fix warnings in android build, fix font rendering issue, fix issue 357588: wrong characters represe… (Closed)

Created:
6 years, 7 months ago by Bo Xu
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix warnings in android build, fix font rendering issue, fix issue 357588: wrong characters representation, and addjust some code indent BUG= R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5dc4f24

Patch Set 1 #

Patch Set 2 : Patch Set after rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -76 lines) Patch
M core/include/fxcrt/fx_system.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 4 chunks +20 lines, -28 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 2 chunks +15 lines, -18 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/mct.c View 1 2 chunks +1 line, -2 lines 0 comments Download
M core/src/fxcrt/fx_basic_coords.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/fx_freetype/fxft2.5.01/src/cff/cf2font.c View 2 chunks +1 line, -2 lines 0 comments Download
M core/src/fxge/fx_freetype/fxft2.5.01/src/cff/cf2ft.c View 4 chunks +13 lines, -4 lines 0 comments Download
M core/src/fxge/fx_freetype/fxft2.5.01/src/cff/cf2hints.c View 5 chunks +5 lines, -0 lines 0 comments Download
M core/src/fxge/fx_freetype/fxft2.5.01/src/cff/cf2intrp.c View 14 chunks +13 lines, -4 lines 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bo Xu
Hi John, can you review these fix for android compile warning, issue 357588 and font ...
6 years, 7 months ago (2014-05-23 22:29:17 UTC) #1
jam
On 2014/05/23 22:29:17, bo_xu wrote: > Hi John, can you review these fix for android ...
6 years, 7 months ago (2014-05-24 01:36:24 UTC) #2
Bo Xu
The CQ bit was checked by bo_xu@foxitsoftware.com
6 years, 7 months ago (2014-05-24 01:40:39 UTC) #3
Bo Xu
The CQ bit was unchecked by bo_xu@foxitsoftware.com
6 years, 7 months ago (2014-05-24 01:40:41 UTC) #4
Bo Xu
6 years, 7 months ago (2014-05-24 19:20:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r5dc4f24 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698