Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 2943463002: Implement dumb URLLoader{Factory} for ServiceWorker script loading (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index 16f558184c0fd5d48d50acf24fe947d5686a2718..ac6eb2a42eadf248a912bf3ef461c299aff70b74 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -911,14 +911,7 @@ void ServiceWorkerVersion::OnDetached(EmbeddedWorkerStatus old_status) {
}
void ServiceWorkerVersion::OnScriptLoaded() {
- DCHECK(GetMainScriptHttpResponseInfo() ||
- // TODO(scottmg|falken): This DCHECK is currently triggered in
- // --network-service because ServiceWorkerReadFromCacheJob isn't being
- // used to retrieve the service worker js. This should be removed once
- // that's done.
- (IsBrowserSideNavigationEnabled() &&
- base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableNetworkService)));
+ DCHECK(GetMainScriptHttpResponseInfo());
if (IsInstalled(status()))
UMA_HISTOGRAM_BOOLEAN("ServiceWorker.ScriptLoadSuccess", true);
}

Powered by Google App Engine
This is Rietveld 408576698