Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2751)

Unified Diff: chrome/browser/resources/ssl/overridable_v2.js

Issue 294343004: New SSL interstitial (behind Finch flag) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fix Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/ssl/overridable_v2.js
diff --git a/chrome/browser/resources/ssl/overridable_v2.js b/chrome/browser/resources/ssl/overridable_v2.js
new file mode 100644
index 0000000000000000000000000000000000000000..0485b2bdbb63d9e2ab31c766ae425eefdaf82f39
--- /dev/null
+++ b/chrome/browser/resources/ssl/overridable_v2.js
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var expandedDetails = false;
+
+function setupEvents() {
+ var clickEventType = ('ontouchstart' in window ? 'touchend' : 'click');
Bernhard Bauer 2014/05/26 10:13:20 Does this mean that we *require* a touch if the de
felt 2014/05/27 12:25:06 Oh, right. I guess on devices like a Pixel there a
felt 2014/05/28 12:56:29 It turns out I just need the 'click', touchscreen
Bernhard Bauer 2014/05/28 13:17:47 OK, cool.
+
+ $('safety-button').addEventListener(clickEventType, function() {
+ sendCommand(CMD_DONT_PROCEED);
+ });
+
+ $('proceed-link').addEventListener(clickEventType, function() {
+ sendCommand(CMD_PROCEED);
+ });
+
+ $('details-button').addEventListener(clickEventType, function() {
+ $('details').classList.toggle('hidden');
+ $('details-button').innerText = $('details').classList.contains('hidden') ?
+ $('details-button').innerText = templateData.openDetails :
Bernhard Bauer 2014/05/26 10:13:20 You already assign the result of the ?: operator.
felt 2014/05/27 12:25:06 Done.
+ $('details-button').innerText = templateData.closeDetails;
+ if (!expandedDetails) {
+ // Record a histogram entry only the first time that details is opened.
+ sendCommand(CMD_MORE);
+ expandedDetails = true;
+ }
+ });
+}
+
+document.addEventListener('DOMContentLoaded', setupEvents);

Powered by Google App Engine
This is Rietveld 408576698