token-server: Fix panic when generating machine token for unrecognized machine.

tokenserver/appengine/impl/machinetoken/rpc_mocks_test.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package machinetoken
 
 // This file contains common mocks used by unit tests.
 
 import (
         "crypto"
@@ skipping 76 matching lines @@
 uwi+mmV6pbwEPKYNHpxHXSbEFnWwnZm1OtM28sP9O0D94XzRq2OfWiiD
 -----END CERTIFICATE-----`
 
 const expectedLuciMachineToken = `CkkKJGx1Y2ktdG9rZW4tc2VydmVyLXRlc3QtMS5mYWtlLmRvbW` +
         `FpbhITc2lnbmVyQHRlc3RpbmcuaG9zdBjykcGmBSCQHCh7MIAgEihmOWRhNWEwZDA5MDN` +
         `iZGE1OGM2ZDY2NGUzODUyYTg5YzI4M2Q3ZmU5GkCrjVagpGYIIVo/OsbQD4Jg8Jbp1l/6` +
         `Q+9t+jHpBXcennnPVb0tKWojPYN3195lZ1ESofXz8rDnXoYF4/2X2pDn`
 
 var testingTime = time.Date(2015, time.February, 3, 4, 5, 6, 0, time.UTC)
 
 var testingCA = certconfig.CA{

[iannucci, 2017/06/20 22:43:19]

@smut: here's the definition of testingCA

[Vadim Sh., 2017/06/20 22:46:01]

yeah... I have no good method of defining global testing constants so they are
discoverable... I myself just do text search in a package when I see a reference
to a global variable.

         CN: "Fake CA: fake.ca",
         ParsedConfig: &admin.CertificateAuthorityConfig{
                 UniqueId: 123,
                 KnownDomains: []*admin.DomainConfig{
                         {
                                 Domain:               []string{"fake.domain"},
                                 MachineTokenLifetime: 3600,
                         },
                 },
         },
         AddedRev:   "cfg-added-rev",
         UpdatedRev: "cfg-updated-rev",
 }
 
-func testingContext() context.Context {
+func testingContext(ca certconfig.CA) context.Context {
         ctx := gaetesting.TestingContext()
         ctx = info.GetTestable(ctx).SetRequestID("gae-request-id")
         ctx, _ = testclock.UseTime(ctx, testingTime)
 
         // Put mocked CA config in the datastore.
-        ca := testingCA
-        ds.Put(ctx, &ca) // put a copy, Put modifies the object
+        ds.Put(ctx, &ca)
         certconfig.StoreCAUniqueIDToCNMap(ctx, map[int64]string{
                 ca.ParsedConfig.UniqueId: ca.CN,
         })
         certconfig.UpdateCRLSet(ctx, ca.CN, certconfig.CRLShardCount, &pkix.CertificateList{})
 
         return ctx
 }
 
 func testingSigner() signing.Signer {
         return signingtest.NewSigner(0, &signing.ServiceInfo{
@@ skipping 47 matching lines @@
         if err != nil {
                 panic(err)
         }
         return crt
 }
 
 func getTestCertDER() []byte {
         block, _ := pem.Decode([]byte(cert))
         return block.Bytes
 }