Android double/triple click

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include <utility>
 
@@ skipping 84 matching lines @@
 #include "ui/gfx/android/view_configuration.h"
 #include "ui/gfx/geometry/dip_util.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/touch_selection/touch_selection_controller.h"
 
 namespace content {
 
 namespace {
 
 static const char kAsyncReadBackString[] = "Compositing.CopyFromSurfaceTime";
+static const double kMaxClickDelay = 0.5;

[aelias_OOO_until_Jul13, 2017/06/20 18:57:52]

Would prefer names "kClickCountInterval", "kClickCountRadiusDIP"

[amaralp, 2017/06/21 00:33:40]

Done.

+static const float kMaxClickDistance = 5;
 
 class PendingReadbackLock;
 
 PendingReadbackLock* g_pending_readback_lock = nullptr;
 
 class PendingReadbackLock : public base::RefCounted<PendingReadbackLock> {
  public:
   PendingReadbackLock() {
     DCHECK_EQ(g_pending_readback_lock, nullptr);
     g_pending_readback_lock = this;
@@ skipping 1679 matching lines @@
   latency_info.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_UI_COMPONENT, 0, 0);
   target_host->ForwardKeyboardEventWithLatencyInfo(event, latency_info);
 }
 
 void RenderWidgetHostViewAndroid::SendMouseEvent(
     const ui::MotionEventAndroid& motion_event,
     int action_button) {
   blink::WebInputEvent::Type webMouseEventType =
       ui::ToWebMouseEventType(motion_event.GetAction());
 
+  const double event_time =
+      ui::EventTimeStampToSeconds(motion_event.GetEventTime());
+  if (webMouseEventType == blink::WebInputEvent::kMouseDown) {

[aelias_OOO_until_Jul13, 2017/06/20 18:57:52]

This also should take into account which button was pressed, for a left-click
quickly followed by a right click.

[amaralp, 2017/06/21 00:33:40]

Made only count left-clicks.

+    gfx::Point mousedown_point(motion_event.GetX(0), motion_event.GetY(0));
+    const double time_delay = event_time - prev_mousedown_timestamp_;
+    const float distance = (mousedown_point - prev_mousedown_point_).Length();
+    if (click_count_ > 2 || time_delay > kMaxClickDelay ||
+        distance > kMaxClickDistance) {
+      click_count_ = 1;

[aelias_OOO_until_Jul13, 2017/06/20 18:57:52]

1-based counting system feels weird.  I'd prefer:

if ([invalid])
  click_count_ = 0;

click_count_++;

[amaralp, 2017/06/21 00:33:40]

Done.

+    } else {
+      click_count_++;
+    }
+    prev_mousedown_timestamp_ = event_time;
+    prev_mousedown_point_ = mousedown_point;
+  }
+
   blink::WebMouseEvent mouse_event = WebMouseEventBuilder::Build(
-      webMouseEventType,
-      ui::EventTimeStampToSeconds(motion_event.GetEventTime()),
-      motion_event.GetX(0), motion_event.GetY(0), motion_event.GetFlags(),
-      motion_event.GetButtonState() ? 1 : 0 /* click count */,
+      webMouseEventType, event_time, motion_event.GetX(0), motion_event.GetY(0),
+      motion_event.GetFlags(),
+      motion_event.GetButtonState() ? click_count_ : 0 /* click count */,

[aelias_OOO_until_Jul13, 2017/06/20 18:57:52]

I suggest integrating this condition in the core click_count_ setting logic
above instead.  You'll need to check button state to distinguish left/right
buttons anyway.

[amaralp, 2017/06/21 00:33:40]

The problem is that I don't want to set click_count_ to 0 when GetButtonState()
== 0 because a mouse hover shouldn't reset the click_count_. Basically this is
saying that if no buttons are pressed then we shouldn't be using the
click-count.

       motion_event.GetPointerId(0), motion_event.GetPressure(0),
       motion_event.GetOrientation(0), motion_event.GetTiltX(0),
       motion_event.GetTiltY(0), action_button, motion_event.GetToolType(0));
 
   if (!host_ || !host_->delegate())
     return;
 
   if (SiteIsolationPolicy::AreCrossProcessFramesPossible() &&
       host_->delegate()->GetInputEventRouter()) {
     host_->delegate()->GetInputEventRouter()->RouteMouseEvent(
@@ skipping 457 matching lines @@
 
   ui::WindowAndroidCompositor* compositor = window_android->GetCompositor();
   if (!compositor)
     return;
 
   overscroll_controller_ = base::MakeUnique<OverscrollControllerAndroid>(
       overscroll_refresh_handler, compositor, view_.GetDipScale());
 }
 
 }  // namespace content