Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3520)

Unified Diff: chrome/common/thumbnail_capturer.mojom

Issue 2943363003: Fixing transparent pixels appearing black when rendered for the context menu. (Closed)
Patch Set: creating and implementing ImageFormat enum Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/tab_contents/core_tab_helper.cc ('k') | chrome/renderer/chrome_render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/thumbnail_capturer.mojom
diff --git a/chrome/common/thumbnail_capturer.mojom b/chrome/common/thumbnail_capturer.mojom
index 71bf82c2777c403aa95c1ad8b3fed1626c8be20b..9fc165102d679c27095d89c088803625157f71b2 100644
--- a/chrome/common/thumbnail_capturer.mojom
+++ b/chrome/common/thumbnail_capturer.mojom
@@ -6,13 +6,20 @@ module chrome.mojom;
import "ui/gfx/geometry/mojo/geometry.mojom";
+enum ImageFormat {
+ JPEG,
+ PNG,
+};
+
interface ThumbnailCapturer {
- // Requests a JPEG encoded thumbnail of the image selected by the most
- // recently opened context menu. If no image is selected or there's an error
- // capturing a thumbnail, |thumbnail_data| will be empty. If the image area is
- // larger than |thumbnail_min_area_pixels| it will be downscaled to fit within
+ // Requests an encoded thumbnail of the image selected by the most recently
+ // opened context menu. The encoding format is specified as a parameter. If
+ // no image is selected or there's an error capturing a thumbnail,
+ // |thumbnail_data| will be empty. If the image area is larger than
+ // |thumbnail_min_area_pixels| it will be downscaled to fit within
// |thumbnail_max_size_pixels|.
RequestThumbnailForContextNode(int32 thumbnail_min_area_pixels,
- gfx.mojom.Size thumbnail_max_size_pixels)
+ gfx.mojom.Size thumbnail_max_size_pixels,
+ ImageFormat image_format)
=> (array<uint8> thumbnail_data, gfx.mojom.Size original_size);
};
« no previous file with comments | « chrome/browser/ui/tab_contents/core_tab_helper.cc ('k') | chrome/renderer/chrome_render_frame_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698