tools/metrics/histograms/enums.xml - Issue 2943333003: Extracting more than one wallpaper prominent color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/enums.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2943333003: Extracting more than one wallpaper prominent color (Closed)

Patch Set: UMA Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/enums.xml

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml

index 8a295e5af1f6c506277f40e5e40d82b8767fad03..75307abbe81517856589f2560f0bf96656071ed4 100644

--- a/tools/metrics/histograms/enums.xml

+++ b/tools/metrics/histograms/enums.xml

@@ -37656,6 +37656,22 @@ from previous Chrome versions.

</enum>

+<enum name="WallpaperColorExtractionResult">

+ <int value="0" label="RESULT_DARK_VIBRANT_TRANSPARENT"/>

Ilya Sherman 2017/06/20 23:00:00 nit: I'd write this in the more human-friendly for

Qiang(Joe) Xu 2017/06/21 01:10:52 I added comments to wallpaper_color_extraction_res

+ <int value="1" label="RESULT_DARK_VIBRANT_OPAQUE"/>

+ <int value="2" label="RESULT_ORMAL_VIBRANT_TRANSPARENT"/>

+ <int value="3" label="RESULT_NORMAL_VIBRANT_OPAQUE"/>

+ <int value="4" label="RESULT_LIGHT_VIBRANT_TRANSPARENT"/>

+ <int value="5" label="RESULT_LIGHT_VIBRANT_OPAQUE"/>

+ <int value="6" label="RESULT_DARK_MUTED_TRANSPARENT"/>

+ <int value="7" label="RESULT_DARK_MUTED_OPAQUE"/>

+ <int value="8" label="RESULT_NORMAL_MUTED_TRANSPARENT"/>

+ <int value="9" label="RESULT_NORMAL_MUTED_OPAQUE"/>

+ <int value="10" label="RESULT_LIGHT_MUTED_TRANSPARENT"/>

+ <int value="11" label="RESULT_LIGHT_MUTED_OPAQUE"/>

+ <int value="12" label="NUM_COLOR_EXTRACTION_RESULTS"/>

Ilya Sherman 2017/06/20 23:00:00 nit: No need to list this, since it won't be recor

Qiang(Joe) Xu 2017/06/21 01:10:52 Done.

+</enum>