Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: third_party/WebKit/LayoutTests/typedcssom/cssRotation.html

Issue 2943303002: [CSS Typed OM] Refactor is2D handling in CSSTransformComponents to match new spec (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
diff --git a/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html b/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
index 22ad92b343248a915e18b333ba5e74436fada85e..194a7c04f732112fff5a59c1de345c3a4e9ce85f 100644
--- a/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
+++ b/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
@@ -33,7 +33,8 @@ var testParams = [
x: 0,
y: 0,
z: 1,
- is2D: true, cssText: "rotate(-21deg)",
+ is2D: true,
+ cssText: "rotate(-21deg)",
asMatrix: new DOMMatrixReadOnly([0.9335804, -0.3583679, 0.3583679, 0.9335804, 0, 0])
},
{
@@ -128,7 +129,7 @@ for (let params of testParams) {
for (let params of testParams) {
test(() => {
- assert_equals(params.input.is2D(), params.is2D);
+ assert_equals(params.input.is2D, params.is2D);
}, "is2D value is correct for " + params.cssText);
}
@@ -143,7 +144,7 @@ for (let params of testParams) {
test(() => {
var transformValue = new CSSTransformValue([input]);
var result = transformValue.toMatrix();
- assert_equals(result.is2D, input.is2D(), 'is2D');
+ assert_equals(result.is2D, input.is2D, 'is2D');
assert_matrix_approx_equals(result, params.asMatrix, EPSILON);
}, "toMatrix works for " + params.cssText);
}

Powered by Google App Engine
This is Rietveld 408576698