[CSS Typed OM] Refactor is2D handling in CSSTransformComponents to match new spec

third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/CSSRotation.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/css/CSSFunctionValue.h"
 #include "core/css/CSSPrimitiveValue.h"
 
@@ skipping 43 matching lines @@
     case CSSValueRotateZ:
       return CSSRotation::Create(0, 0, 1, angle);
     default:
       NOTREACHED();
       return nullptr;
   }
 }
 
 }  // namespace
 
+CSSRotation* CSSRotation::Create(CSSNumericValue* angle,
+                                 ExceptionState& exception_state) {
+  if (angle->GetType() != CSSStyleValue::StyleValueType::kAngleType) {
+    exception_state.ThrowTypeError("Must pass an angle to CSSRotation");
+    return nullptr;
+  }
+  return new CSSRotation(0, 0, 1, angle, true /* is2D */);
+}
+
 CSSRotation* CSSRotation::Create(double x,
                                  double y,
                                  double z,
                                  CSSNumericValue* angle,
                                  ExceptionState& exception_state) {
   if (angle->GetType() != CSSStyleValue::StyleValueType::kAngleType) {
     exception_state.ThrowTypeError("Must pass an angle to CSSRotation");
     return nullptr;
   }
-  return new CSSRotation(x, y, z, angle);
+  return new CSSRotation(x, y, z, angle, false /* is2D */);
+}
+
+CSSRotation* CSSRotation::Create(CSSNumericValue* angle) {
+  DCHECK_EQ(angle->GetType(), CSSStyleValue::StyleValueType::kAngleType);
+  return new CSSRotation(0, 0, 1, angle, true /* is2D */);
 }
 
 CSSRotation* CSSRotation::Create(double x,
                                  double y,
                                  double z,
                                  CSSNumericValue* angle) {
   DCHECK_EQ(angle->GetType(), CSSStyleValue::StyleValueType::kAngleType);
-  return new CSSRotation(x, y, z, angle);
+  return new CSSRotation(x, y, z, angle, false /* is2D */);
 }
 
 CSSRotation* CSSRotation::FromCSSValue(const CSSFunctionValue& value) {
   switch (value.FunctionType()) {
     case CSSValueRotate:
       return FromCSSRotate(value);
     case CSSValueRotate3d:
       return FromCSSRotate3d(value);
     case CSSValueRotateX:
     case CSSValueRotateY:
@@ skipping 16 matching lines @@
     return;
   }
   angle_ = angle;
 }
 
 CSSFunctionValue* CSSRotation::ToCSSValue() const {
   return nullptr;
   // TODO(meade): Re-implement this when we finish rewriting number/length
   // types.
   // CSSFunctionValue* result =
-  //     CSSFunctionValue::Create(is2d_ ? CSSValueRotate : CSSValueRotate3d);
-  // if (!is2d_) {
+  //     CSSFunctionValue::Create(is2D() ? CSSValueRotate : CSSValueRotate3d);
+  // if (!is2D()) {
   //   result->Append(
   //      *CSSPrimitiveValue::Create(x_, CSSPrimitiveValue::UnitType::kNumber));
   //   result->Append(
   //      *CSSPrimitiveValue::Create(y_, CSSPrimitiveValue::UnitType::kNumber));
   //   result->Append(
   //      *CSSPrimitiveValue::Create(z_, CSSPrimitiveValue::UnitType::kNumber));
   // }
   // result->Append(*CSSPrimitiveValue::Create(angle_->Value(),
   //                                           angle_->Unit()));
   // return result;
 }
 
 }  // namespace blink