Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2943023002: Change type of ClosureTask to ClosureConversionTask (new supertype) in one other file. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change type of ClosureTask to ClosureConversionTask (new supertype) in one other file. BUG= Committed: https://github.com/dart-lang/sdk/commit/0edf55ceabde4d0ba22062ad9a1ab1b2cb1adde5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Emily Fortuna
TBR, this is breaking one of the bots.
3 years, 6 months ago (2017-06-16 00:23:58 UTC) #2
Emily Fortuna
Committed patchset #1 (id:1) manually as 0edf55ceabde4d0ba22062ad9a1ab1b2cb1adde5 (presubmit successful).
3 years, 6 months ago (2017-06-16 00:24:14 UTC) #4
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-16 00:24:55 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698