Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: extensions/browser/event_router.h

Issue 2943013002: Remove unused EventRouter member function definitions. (Closed)
Patch Set: rm <utility> Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/event_router.h
diff --git a/extensions/browser/event_router.h b/extensions/browser/event_router.h
index 25933c08bfe35a887dbe21b93fc77b7276730cca..f0c5d0fcbe814a9a590d21a7f21c5c49e638774c 100644
--- a/extensions/browser/event_router.h
+++ b/extensions/browser/event_router.h
@@ -8,7 +8,6 @@
#include <set>
#include <string>
#include <unordered_map>
-#include <utility>
#include "base/callback.h"
#include "base/compiler_specific.h"
@@ -242,11 +241,6 @@ class EventRouter : public KeyedService,
kServiceWorker,
};
- // An identifier for an event dispatch that is used to prevent double dispatch
- // due to race conditions between the direct and lazy dispatch paths.
- typedef std::tuple<const content::BrowserContext*, std::string, int>
- EventDispatchIdentifier;
-
// TODO(gdk): Document this.
static void DispatchExtensionMessage(
IPC::Sender* ipc_sender,
@@ -287,15 +281,6 @@ class EventRouter : public KeyedService,
void DispatchEventImpl(const std::string& restrict_to_extension_id,
const linked_ptr<Event>& event);
- // Ensures that all lazy background pages that are interested in the given
- // event are loaded, and queues the event if the page is not ready yet.
- // Inserts an EventDispatchIdentifier into |already_dispatched| for each lazy
- // event dispatch that is queued.
- void DispatchLazyEvent(const std::string& extension_id,
- const linked_ptr<Event>& event,
- std::set<EventDispatchIdentifier>* already_dispatched,
- const base::DictionaryValue* listener_filter);
-
// Dispatches the event to the specified extension or URL running in
// |process|.
void DispatchEventToProcess(const std::string& extension_id,
@@ -306,15 +291,6 @@ class EventRouter : public KeyedService,
const base::DictionaryValue* listener_filter,
bool did_enqueue);
- // Possibly loads given extension's background page in preparation to
- // dispatch an event. Returns true if the event was queued for subsequent
- // dispatch, false otherwise.
- bool MaybeLoadLazyBackgroundPageToDispatchEvent(
- content::BrowserContext* context,
- const Extension* extension,
- const linked_ptr<Event>& event,
- const base::DictionaryValue* listener_filter);
-
// Adds a filter to an event.
void AddFilterToEvent(const std::string& event_name,
const std::string& extension_id,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698