Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4069)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java

Issue 2942963002: corrected wrong options showing on context menus. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
index 0a202f066e61f590759760f9b8ba34d4bba4c50a..4ff0bd5c8af0c409ee3d8d05df3e0112a79a93ec 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
@@ -61,6 +61,10 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
mNativeContextMenuHelper = 0;
}
+ public Activity getActivity() {
gone 2017/06/15 22:05:11 1) package protected instead of public 2) add jav
Daniel Park 2017/06/16 00:03:15 Done.
+ return mActivity;
+ }
+
/**
* @param populator A {@link ContextMenuPopulator} that is responsible for managing and showing
* context menus.
@@ -224,6 +228,7 @@ public class ContextMenuHelper implements OnCreateContextMenuListener {
public void onCreateContextMenu(ContextMenu menu, View v, ContextMenuInfo menuInfo) {
List<Pair<Integer, List<ContextMenuItem>>> items =
mPopulator.buildContextMenu(menu, v.getContext(), mCurrentContextMenuParams);
+
if (items.isEmpty()) {
ThreadUtils.postOnUiThread(mOnMenuClosed);
return;

Powered by Google App Engine
This is Rietveld 408576698