Implementing sign-in promo histograms for bookmark

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index b99d769b2489f47fde23e8c21ec037eeb70fbae8..cf9e6766442c612886c2c45d8f47516a55692d31 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -32490,6 +32490,35 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="MobileSignInPromo.BookmarkManager.CountTilSignin"

[rkaplow, 2017/06/27 21:13:57]

I'd prefer a more specific name, i.e. Clicks versus 'Count'.

Also looking again - why is this 'til'? I don't see any temporal restriction
here (based on the description).

Could this be clearer as SigninClicks?

[jlebel, 2017/06/28 11:10:31]

The bucket is number of time the sign-in promo has been displayed when the user
clicks on the sign-in buttons. If it's ok with you I change it to:
MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButton

[jlebel, 2017/06/28 11:37:52]

I meant MobileSignInPromo.BookmarkManager.ImpressionsTilSigninButtons since we
have more than one sign-in button.

+    units="display count until sign-in">

[rkaplow, 2017/06/27 21:13:57]

Usuallu we keep the unit short (something like 'clicks').

[jlebel, 2017/06/28 11:10:31]

Done.

+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times one of the &quot;sign in&quot; buttons (any of the
+    signed-out &quot;Sign in to Chrome&quot; button, the &quot;Continue as
+    |name|&quot; button, or the &quot;Not |email|?&quot; button) is clicked per
+    impression.
+  </summary>
+</histogram>
+
+<histogram name="MobileSignInPromo.BookmarkManager.CountTilX"

[rkaplow, 2017/06/27 21:13:57]

similar - XButtonClicks or something? That seems much clearer to me

[jlebel, 2017/06/28 11:10:31]

I choose:
MobileSignInPromo.BookmarkManager.ImpressionsTilXButton

+    units="display count until closing">
+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times the explicit &quot;X&quot;-to-close button is clicked
+    per impression.
+  </summary>
+</histogram>
+
+<histogram name="MobileSignInPromo.BookmarkManager.DismissalCount"
+    units="display count until bookmark closed">

[rkaplow, 2017/06/27 21:13:57]

dismissals as unit I would suggest

[jlebel, 2017/06/28 11:10:31]

Done.

+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times the signin promo is implicitly dismissed (by closing
+    the bookmark manager) per impression.
+  </summary>
+</histogram>
+
 <histogram name="MobileStartup.IntentToCreationTime" units="ms">
   <owner>twellington@chromium.org</owner>
   <summary>