Implementing sign-in promo histograms for bookmark

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 8295bb05a3698cfc2c07c47947e6f9e1046fab73..3dcce2db83062795769f9abe147f6648e4ba78b1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -32300,6 +32300,32 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="MobileSignInPromo.BookmarkManager.CountTilSignin">

[rkaplow, 2017/06/23 19:33:50]

units required for all histograms

[rkaplow, 2017/06/23 19:33:50]

I would mention what this is counting - something like
ButtonClicksUntilSignin 
?

[jlebel, 2017/06/23 23:42:36]

Does it work like that? Sorry, I'm new in histograms.

+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times one of the &quot;sign in&quot; buttons (any of the
+    signed-out &quot;Sign in to Chrome&quot; button, the &quot;Continue as
+    |name|&quot; button, or the &quot;Not |email|?&quot; button) is clicked per
+    impression.
+  </summary>
+</histogram>
+
+<histogram name="MobileSignInPromo.BookmarkManager.CountTilX">
+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times the explicit &quot;X&quot;-to-close button is clicked
+    per impression.
+  </summary>
+</histogram>
+
+<histogram name="MobileSignInPromo.BookmarkManager.DismissalCount">
+  <owner>jlebel@chromium.org</owner>
+  <summary>
+    Counts how many times the signin promo is implicitly dismissed (by closing
+    the bookmark manager) per impression.
+  </summary>
+</histogram>
+
 <histogram name="MobileStartup.IntentToCreationTime" units="ms">
   <owner>twellington@chromium.org</owner>
   <summary>