ios/chrome/browser/ui/settings/settings_collection_view_controller.mm - Issue 2942923002: Implementing sign-in promo histograms for bookmark

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Issue 2942923002: Implementing sign-in promo histograms for bookmark (Closed)

Patch Set: . Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h ('K') | « ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_table_view_controller.mm ('k') | ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

index 4dca72bacc033f03f5692c1182479325a150701d..0a0be21439f7947f84def8f8a4259e2b11a4a545 100644

--- a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

@@ -336,7 +336,8 @@ void SigninObserverBridge::GoogleSignedOut(const std::string& account_id,

_hasRecordedSigninImpression = YES;

}

if (experimental_flags::IsSigninPromoEnabled()) {

- _signinPromoViewMediator = [[SigninPromoViewMediator alloc] init];

+ _signinPromoViewMediator = [[SigninPromoViewMediator alloc]

+ initWithBrowserState:_currentBrowserState];

_signinPromoViewMediator.consumer = self;

}

[model addItem:[self signInTextItem]