Implementing sign-in promo histograms for bookmark

ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h

Index: ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h
diff --git a/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h b/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h
index 3a41ff8097b970d491e423679a406399bce67433..9c031e368bb3a1feb59cd2377b5306d5a94fbf0b 100644
--- a/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h
+++ b/ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h
@@ -14,6 +14,10 @@
 @class SigninPromoViewConfigurator;
 @protocol SigninPromoViewConsumer;
 
+namespace ios {
+class ChromeBrowserState;
+}  // namespace ios
+
 // Class that monitors the available identities and creates
 // SigninPromoViewConfigurator. This class makes the link between the model and
 // the view. The consumer will receive notification if default identity is
@@ -30,8 +34,39 @@
 // Access point used to send user action metrics.
 @property(nonatomic) signin_metrics::AccessPoint accessPoint;
 
+// Preference key to count how many time the sign-in promo view is seen.
+@property(nonatomic) std::string displayedCountPreferenceKey;
+// Preference key, set to true when the sign-in promo view is seen too much.
+@property(nonatomic) std::string alreadySeenSigninViewPreferenceKey;
+// Histogram name to count how many times the signin promo is implicitly
+// dismissed per impression.
+@property(nonatomic) std::string dismissalCountHistogramName;
+// Histogram name to count how many times one of the "sign in" buttons is
+// clicked per impression.
+@property(nonatomic) std::string countTilSigninHistogramName;

[sdefresne, 2017/06/19 09:07:50]

Shouldn't this be "countTillSigninHistogramName"?

[jlebel, 2017/06/19 14:38:12]

According to google, both works (it looks like "till" is more format). But "til"
has been asked by my american PM.

[sdefresne, 2017/06/22 12:40:38]

Ack. Didn't knew it was an US vs UK english difference.

[jlebel, 2017/06/23 01:24:06]

Acknowledged.

+// Histogram name to counts how many times the explicit "X"-to-close button is
+// clicked per impression.
+@property(nonatomic) std::string countTilXHistogramName;

[sdefresne, 2017/06/19 09:07:50]

Shouldn't this be "countTillXHistogramName"?

[jlebel, 2017/06/19 14:38:12]

See above.

+
+// See -[SigninPromoViewMediator initWithBrowserState:].
+- (instancetype)init NS_UNAVAILABLE;
+
+// Initialises with browser state.
+- (instancetype)initWithBrowserState:(ios::ChromeBrowserState*)browserState
+    NS_DESIGNATED_INITIALIZER;
+
 - (SigninPromoViewConfigurator*)createConfigurator;
 
+// Increments the "shown" counter used for histograms. Called when the signin
+// promo view is visible
+- (void)signinPromoViewVisible;
+
+// Called when the sign-in promo view is hidden.
+- (void)signinPromoViewHidden;
+
+// Called when the sign-in promo view is dismissed.
+- (void)signinPromoViewDismissed;
+
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_VIEW_MEDIATOR_H_