pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2942863002: Compile and run Hello World!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2942863002: Compile and run Hello World! (Closed)

Patch Set: Rebased Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index d4c7fc3e2d169779b01ace9e8b9d67e532caf406..01b1c65980928a0cf21bacb2f3649ef64507c844 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -440,9 +440,9 @@ class ProgramBuilder {

return staticNonFinalFields.map(_buildStaticField).toList(growable: false);

}

- StaticField _buildStaticField(FieldElement element) {

+ StaticField _buildStaticField(FieldEntity element) {

ConstantValue initialValue =

- _constantHandler.getConstantValue(element.constant);

+ _worldBuilder.getConstantFieldInitializer(element);

// TODO(zarah): The holder should not be registered during building of

// a static field.

_registry.registerHolder(_namer.globalObjectForConstant(initialValue),