Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart

Issue 2942863002: Compile and run Hello World! (Closed)
Patch Set: Cleanup Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart b/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart
index 074b06c920a032de36efa22579eb0b1032e252c9..4eef86d51dc527b4ecfaa058f1db377ca40208ee 100644
--- a/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart
@@ -274,7 +274,8 @@ class KernelToLocalsMapImpl implements KernelToLocalsMap {
@override
JumpTarget getJumpTarget(ir.TreeNode node, {bool isContinueTarget: false}) {
- throw new UnimplementedError('KernelToLocalsMapImpl.getJumpTarget');
+ // TODO(johnniwinther): Support jump targets.
+ return null;
Emily Fortuna 2017/06/15 17:54:34 is this really better than throwing? I mean, it ge
Siggi Cherem (dart-lang) 2017/06/15 18:28:55 one option here: throw in checked mode only?
Johnni Winther 2017/06/16 09:25:31 This is the price for the machete approach. We nee
Siggi Cherem (dart-lang) 2017/06/16 16:35:24 How about: if (const bool.fromEnvironment("MACHET
Johnni Winther 2017/06/19 10:57:38 I'll consider it.
}
@override

Powered by Google App Engine
This is Rietveld 408576698