Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: ui/gfx/render_text_harfbuzz.cc

Issue 2942843002: RenderText: always break runs at whitespace (Closed)
Patch Set: Helper method comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_harfbuzz.cc
diff --git a/ui/gfx/render_text_harfbuzz.cc b/ui/gfx/render_text_harfbuzz.cc
index 912ebb2e555962bace34df0facaeb2590dedac04..fe492c69f1600ce59f5cab612018ef778e7541f8 100644
--- a/ui/gfx/render_text_harfbuzz.cc
+++ b/ui/gfx/render_text_harfbuzz.cc
@@ -173,7 +173,6 @@ size_t FindRunBreakingCharacter(const base::string16& text,
// Consider 3 characters with the script values {Kana}, {Hira, Kana}, {Kana}.
// Without script extensions only the first script in each set would be taken
// into account, resulting in 3 runs where 1 would be enough.
-// TODO(ckocagil): Write a unit test for the case above.
int ScriptInterval(const base::string16& text,
size_t start,
size_t length,
@@ -187,9 +186,6 @@ int ScriptInterval(const base::string16& text,
*script = scripts[0];
while (char_iterator.Advance()) {
- // Special handling to merge white space into the previous run.
- if (u_isUWhiteSpace(char_iterator.get()))
- continue;
ScriptSetIntersect(char_iterator.get(), scripts, &scripts_size);
if (scripts_size == 0U)
return char_iterator.array_pos();
« no previous file with comments | « no previous file | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698