Issue 2942753002: Enable 'analysis.implemented' with the new analysis driver.

Issue 2942753002: Enable 'analysis.implemented' with the new analysis driver. (Closed)

Created:
3 years, 6 months ago by scheglov

Modified:
3 years, 6 months ago

Reviewers:
devoncarew, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Enable 'analysis.implemented' with the new analysis driver. It is not very efficient on large files, but works well enough for small files. I will work on making it more efficient in following CLs. R=brianwilkerson@google.com, devoncarew@google.com BUG= https://github.com/dart-lang/sdk/issues/29113 Committed: https://github.com/dart-lang/sdk/commit/9600dab0e0f93123db949e49d3c6222008d8a827

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -71 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/operation/operation_analysis.dart	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_implemented_test.dart	View	23 chunks	+0 lines, -69 lines	0 comments	Download

Total messages: 5 (1 generated)

devoncarew

The actual changes look good to me (and a surprisingly small delta!). I am however ...

3 years, 6 months ago (2017-06-14 22:42:38 UTC) #2

scheglov

3 years, 6 months ago (2017-06-16 16:13:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9600dab0e0f93123db949e49d3c6222008d8a827 (presubmit successful).