[cast_channel] Clean up CastSocketImpl ctor parameters

components/cast_channel/cast_socket.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cast_channel/cast_socket.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include <utility>
@@ skipping 71 matching lines @@
     return net::OK;
   }
 };
 
 }  // namespace
 
 using ChannelError = ::cast_channel::ChannelError;
 using ChannelAuthType = ::cast_channel::ChannelAuthType;
 using ReadyState = ::cast_channel::ReadyState;
 
-CastSocketImpl::CastSocketImpl(const std::string& owner_extension_id,
-                               const net::IPEndPoint& ip_endpoint,
-                               ChannelAuthType channel_auth,
+CastSocketImpl::CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                                net::NetLog* net_log,
                                const base::TimeDelta& timeout,
                                bool keep_alive,
                                const scoped_refptr<Logger>& logger,
                                uint64_t device_capabilities)
-    : CastSocketImpl(owner_extension_id,
-                     ip_endpoint,
-                     channel_auth,
+    : CastSocketImpl(ip_endpoint,
                      net_log,
                      timeout,
                      keep_alive,
                      logger,
                      device_capabilities,
                      AuthContext::Create()) {}
 
-CastSocketImpl::CastSocketImpl(const std::string& owner_extension_id,
-                               const net::IPEndPoint& ip_endpoint,
-                               ChannelAuthType channel_auth,
+CastSocketImpl::CastSocketImpl(const net::IPEndPoint& ip_endpoint,
                                net::NetLog* net_log,
                                const base::TimeDelta& timeout,
                                bool keep_alive,
                                const scoped_refptr<Logger>& logger,
                                uint64_t device_capabilities,
                                const AuthContext& auth_context)
     : channel_id_(0),
       ip_endpoint_(ip_endpoint),
-      channel_auth_(channel_auth),
+      channel_auth_(ChannelAuthType::SSL_VERIFIED),

[imcheng, 2017/06/14 22:25:34]

Can we remove this field and just hardcode SSL_VERIFIED wherever channel_auth_ /
(channel_auth()) is used?


It seems like we can remove ChannelAuthType entirely; but we may have to do it
in stages since it's also defined in the Cast Channel API IDL. 

[zhaobin, 2017/06/15 02:22:22]

Done.

       net_log_(net_log),
       keep_alive_(keep_alive),
       logger_(logger),
       auth_context_(auth_context),
       connect_timeout_(timeout),
       connect_timeout_timer_(new base::OneShotTimer),
       is_canceled_(false),
       device_capabilities_(device_capabilities),
       audio_only_(false),
       connect_state_(proto::CONN_STATE_START_CONNECT),
@@ skipping 469 matching lines @@
 void CastSocketImpl::SetErrorState(ChannelError error_state) {
   VLOG_WITH_CONNECTION(1) << "SetErrorState "
                           << ::cast_channel::ChannelErrorToString(error_state);
   DCHECK_EQ(ChannelError::NONE, error_state_);
   error_state_ = error_state;
   delegate_->OnError(error_state_);
 }
 
 }  // namespace cast_channel
 #undef VLOG_WITH_CONNECTION