Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js

Issue 2942573003: [DevTools] New harness for inspector-protocol layout tests (Closed)
Patch Set: Protocol -> dp Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js
diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.html b/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js
similarity index 20%
rename from third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.html
rename to third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js
index f084a6e6081147631595494c9690e8e748851cd9..577d3c4048201391db3b023b1bff3819e3cd426c 100644
--- a/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.html
+++ b/third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-ignoredNodesModal.js
@@ -1,31 +1,21 @@
-<html>
-<head>
-<script type="text/javascript" src="../../http/tests/inspector-protocol/dom-protocol-test.js"></script>
-<script type="text/javascript" src="../../http/tests/inspector-protocol/inspector-protocol-test.js"></script>
-<script type="text/javascript" src="accessibility-dumpAccessibilityNodes.js"></script>
-<script>
-
-function test()
-{
- InspectorTest.sendCommand("DOM.getDocument", {}, (msg) => {
- InspectorTest.dumpAccessibilityNodesBySelectorAndCompleteTest("[data-dump]", false, msg);
- });
-}
-</script>
-<style>
-body.done * {
- display: none;
-}
-</style>
-</head>
-<body onLoad="runTest();">
+(async function(testRunner) {
+ let {page, session, dp} = await testRunner.startHTML(`
+ <style>
+ body.done * {
+ display: none;
+ }
+ </style>
<div data-dump>Hidden by modal dialog</div>
<dialog data-dump>
(Dialog itself is not hidden)
<div data-dump>Non-hidden element inside dialog</div>
</dialog>
- <script>
- document.querySelector("dialog").showModal();
- </script>
-</body>
-</html>
+ `, '');
+
+ var dumpAccessibilityNodesBySelectorAndCompleteTest =
+ (await testRunner.loadScript('../resources/accessibility-dumpAccessibilityNodes.js'))(testRunner, session);
+
+ await session.evaluate('document.querySelector("dialog").showModal();');
+ var msg = await dp.DOM.getDocument();
+ dumpAccessibilityNodesBySelectorAndCompleteTest('[data-dump]', false, msg);
+})

Powered by Google App Engine
This is Rietveld 408576698