Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2942573002: Copy fasta analyze_test to dart2js. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/front_end/test/fasta/analyze_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/fasta_analyze_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ahe
Copy Fasta test to dart2js unit tests to help detect problems in dart2js.
3 years, 6 months ago (2017-06-14 11:44:50 UTC) #3
Johnni Winther
lgtm
3 years, 6 months ago (2017-06-14 12:17:29 UTC) #4
ahe
Committed patchset #1 (id:20001) manually as a189be6786c6415f9b3cbae6dc42af8074ec47e8 (presubmit successful).
3 years, 6 months ago (2017-06-14 13:00:51 UTC) #6
Emily Fortuna
3 years, 6 months ago (2017-06-14 17:08:12 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698