Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4258)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/installable/installable_logging.cc

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)
Patch Set: Fix windows compile Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/installable/installable_logging.h ('k') | chrome/browser/installable/installable_manager.h » ('j') | chrome/browser/installable/installable_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/installable/installable_logging.cc
diff --git a/chrome/browser/installable/installable_logging.cc b/chrome/browser/installable/installable_logging.cc
index 00903a719a1ae4cfe5720aaee13f704a0240d8b4..7d2f89aaf72082c536f5d33ece4c02b1ae87dfdb 100644
--- a/chrome/browser/installable/installable_logging.cc
+++ b/chrome/browser/installable/installable_logging.cc
@@ -86,6 +86,8 @@ void LogErrorToConsole(content::WebContents* web_contents,
case SHOWING_NATIVE_APP_BANNER:
case SHOWING_WEB_APP_BANNER:
case FAILED_TO_CREATE_BANNER:
+ case WAITING_FOR_MANIFEST:
+ case WAITING_FOR_INSTALLABLE_CHECK:
case MAX_ERROR_CODE:
return;
case RENDERER_EXITING:
« chrome/browser/banners/app_banner_manager.cc ('K') | « chrome/browser/installable/installable_logging.h ('k') | chrome/browser/installable/installable_manager.h » ('j') | chrome/browser/installable/installable_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698