Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/browser/banners/app_banner_manager_browsertest.cc

Issue 2942513002: Allow banners to trigger on sites which don't register a service worker onload. (Closed)
Patch Set: Fix windows compile Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager_browsertest.cc
diff --git a/chrome/browser/banners/app_banner_manager_browsertest.cc b/chrome/browser/banners/app_banner_manager_browsertest.cc
index 61565d65a29f0d43ffaf58f77df0cf531ccf7ad5..fb4fa4f531860998780e18affb004742072f7a95 100644
--- a/chrome/browser/banners/app_banner_manager_browsertest.cc
+++ b/chrome/browser/banners/app_banner_manager_browsertest.cc
@@ -232,6 +232,16 @@ IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, WebAppBannerCreated) {
engagement_scores, SHOWING_WEB_APP_BANNER, true);
}
+IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
+ WebAppBannerLazyServiceWorker) {
+ std::unique_ptr<AppBannerManagerTest> manager(
+ CreateAppBannerManager(browser()));
+ std::vector<double> engagement_scores{0, 10};
+ RunBannerTest(browser(), manager.get(),
+ "/banners/lazy_service_worker_test_page.html",
+ engagement_scores, SHOWING_WEB_APP_BANNER, true);
+}
+
IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
WebAppBannerCreatedImmediately) {
std::unique_ptr<AppBannerManagerTest> manager(

Powered by Google App Engine
This is Rietveld 408576698